[jira] [Comment Edited] (CASSANDRA-10576) Thrift CAS on static columns doesn't work as expected

["Sam Tunnicliffe (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CASSANDRA-10576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14971047#comment-14971047 ] 

Sam Tunnicliffe edited comment on CASSANDRA-10576 at 10/23/15 2:12 PM:
-----------------------------------------------------------------------

This wasn't covered by the existing dtest, so I've refactored & extended it to cover static/dynamic/mixed CFs [here|https://github.com/riptano/cassandra-dtest/pull/626]
{{thrift_tests:TestMutations.test_cas}} fails against cassandra-3.0/trunk but with the changes in the linked branches, it's now passing.

||3.0||trunk||
|[branch|https://github.com/beobal/cassandra/tree/10576-3.0]|[branch|https://github.com/beobal/cassandra/tree/10576-trunk]|
|[testall|http://cassci.datastax.com/view/Dev/view/beobal/job/beobal-10576-3.0-testall/]|[testall|http://cassci.datastax.com/view/Dev/view/beobal/job/beobal-10576-trunk-testall/]|
|[dtests|http://cassci.datastax.com/view/Dev/view/beobal/job/beobal-10576-3.0-dtest/]|[dtests|http://cassci.datastax.com/view/Dev/view/beobal/job/beobal-10576-trunk-dtest/]|



was (Author: beobal):
This wasn't covered by the existing dtest, so I've refactored & extended it to cover static/dynamic/mixed CFs [here:https://github.com/riptano/cassandra-dtest/pull/626]
{{thrift_tests:TestMutations.test_cas}} fails against cassandra-3.0/trunk but with the changes in the linked branches, it's now passing.

||3.0||trunk||
|[branch|https://github.com/beobal/cassandra/tree/10576-3.0]|[branch|https://github.com/beobal/cassandra/tree/10576-trunk]|
|[testall|http://cassci.datastax.com/view/Dev/view/beobal/job/beobal-10576-3.0-testall/]|[testall|http://cassci.datastax.com/view/Dev/view/beobal/job/beobal-10576-trunk-testall/]|
|[dtests|http://cassci.datastax.com/view/Dev/view/beobal/job/beobal-10576-3.0-dtest/]|[dtests|http://cassci.datastax.com/view/Dev/view/beobal/job/beobal-10576-trunk-dtest/]|


> Thrift CAS on static columns doesn't work as expected
> -----------------------------------------------------
>
>                 Key: CASSANDRA-10576
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-10576
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Sam Tunnicliffe
>            Assignee: Sam Tunnicliffe
>             Fix For: 3.0.0
>
>
> Although the thrift cas call works as expected for dynamic column families, using it on tables with statically defined columns produces unexpected results. The problem, in {{ThriftCASRequest}}, is that while the {{expected}} partition contains a static row, the {{current}} partition has been processed by {{ThriftResultsMerger}} during the read, converting the static columns to clusterings. If {{expected}} contains only a static row, no further checking is carried out, {{appliesTo}} erroneously returns true and the conditional update is performed regardless of the current state of the partition.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)