You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@madlib.apache.org by GitBox <gi...@apache.org> on 2020/05/19 22:57:22 UTC

[GitHub] [madlib] orhankislal opened a new pull request #499: DBSCAN: Fix predict on Greenplum

orhankislal opened a new pull request #499:
URL: https://github.com/apache/madlib/pull/499


   The previous dbscan_predict implementation failed on greenplum
   if called on a table since the UDFs running on segments cannot
   access tables. This implementation creates an output table to
   fix this issue.
   
   <!--  
   
   Thanks for sending a pull request!  Here are some tips for you:
   1. Refer to this link for contribution guidelines https://cwiki.apache.org/confluence/display/MADLIB/Contribution+Guidelines
   2. Please Provide the Module Name, a JIRA Number and a short description about your changes.
   -->
   
   - [ ] Add the module name, JIRA# to PR/commit and description.
   - [ ] Add tests for the change. 
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [madlib] khannaekta commented on a change in pull request #499: DBSCAN: Fix predict on Greenplum

Posted by GitBox <gi...@apache.org>.
khannaekta commented on a change in pull request #499:
URL: https://github.com/apache/madlib/pull/499#discussion_r427681187



##########
File path: src/ports/postgres/modules/dbscan/dbscan.sql_in
##########
@@ -304,6 +338,15 @@ SELECT pid, madlib.dbscan_predict (
                         'dbscan_result',   -- from DBSCAN run

Review comment:
       This example needs to be removed.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [madlib] orhankislal merged pull request #499: DBSCAN: Fix predict on Greenplum

Posted by GitBox <gi...@apache.org>.
orhankislal merged pull request #499:
URL: https://github.com/apache/madlib/pull/499


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org