You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "damccorm (via GitHub)" <gi...@apache.org> on 2023/09/22 14:18:43 UTC

[GitHub] [beam] damccorm commented on a diff in pull request #28615: Add all GHA runs to dashboard

damccorm commented on code in PR #28615:
URL: https://github.com/apache/beam/pull/28615#discussion_r1334446794


##########
.test-infra/metrics/sync/github/sync_workflows.py:
##########
@@ -134,13 +134,11 @@ def fetchWorkflowData():
                 workflows.append(workflowsPage)
         for pageItem in workflows:
             for item in pageItem:
-                path =item['path']
-                isPostCommit = re.search('(.*)postcommit(.*)',path)
-                if isPostCommit:
-                    result = re.search('/(.*).yml', path)
-                    path =(result.group(1)) + ".yml"
-                    workflowObject = Workflow(item['id'],item['name'],path)
-                    WORKFLOWS_OBJECT_LIST.append(workflowObject)
+                path = item['path']
+                result = re.search('/(.*).yml', path)
+                path = (result.group(1)) + ".yml"
+                workflowObject = Workflow(item['id'],item['name'],path)
+                WORKFLOWS_OBJECT_LIST.append(workflowObject)
             url = "https://api.github.com/repos/apache/beam/actions/workflows/"
             queryOptions = { 'branch' : 'master', 'per_page' : GH_WORKFLOWS_NUMBER_EXECUTIONS,

Review Comment:
   I could filter to that, but I _think_ this should be taken care of by filtering out cancelled runs - that's the end result of the trigger phrases IIRC, right?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org