You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/02/18 00:16:58 UTC
[GitHub] [airflow] jedcunningham opened a new pull request #21659: Sync `v2-2-stable` with `v2-2-test` to release `2.2.4`
jedcunningham opened a new pull request #21659:
URL: https://github.com/apache/airflow/pull/21659
Time for `2.2.4rc1`!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] davidism commented on pull request #21659: Sync `v2-2-stable` with `v2-2-test` to release `2.2.4`
Posted by GitBox <gi...@apache.org>.
davidism commented on pull request #21659:
URL: https://github.com/apache/airflow/pull/21659#issuecomment-1044575400
OK, I knew Airflow was good about pinning and updates, just wanted to make sure I understood. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #21659: Sync `v2-2-stable` with `v2-2-test` to release `2.2.4`
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #21659:
URL: https://github.com/apache/airflow/pull/21659#issuecomment-1044380157
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk edited a comment on pull request #21659: Sync `v2-2-stable` with `v2-2-test` to release `2.2.4`
Posted by GitBox <gi...@apache.org>.
potiuk edited a comment on pull request #21659:
URL: https://github.com/apache/airflow/pull/21659#issuecomment-1044572024
> Pinning to MarkupSafe<2.1 or Jinja<3 should only be short term fixes, neither version range is supported.
Yep it is short term - see the comment. But For 2.2.4 it is safe bet. 2.2.5 or 2.3.0 shoudl have it lifted providing that we fix it.
> Markupsafe 2.1.0 breaks with error: import name 'soft_unicode' from 'markupsafe'.
This should be removed when either this issue is closed:
https://github.com/pallets/markupsafe/issues/284
or when we will be able to upgrade JINJA to newer version (currently
limited due to Flask and Flask Application Builder)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] davidism commented on pull request #21659: Sync `v2-2-stable` with `v2-2-test` to release `2.2.4`
Posted by GitBox <gi...@apache.org>.
davidism commented on pull request #21659:
URL: https://github.com/apache/airflow/pull/21659#issuecomment-1044539727
Pinning to MarkupSafe<2.1 or Jinja<3 should only be short term fixes, neither version range is supported.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #21659: Sync `v2-2-stable` with `v2-2-test` to release `2.2.4`
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #21659:
URL: https://github.com/apache/airflow/pull/21659#issuecomment-1044417569
@jedcunningham - I added the cherry-pick and added a fixup to the changelog - feel free to reset it if you think it's something that shoudl not be added of course :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #21659: Sync `v2-2-stable` with `v2-2-test` to release `2.2.4`
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #21659:
URL: https://github.com/apache/airflow/pull/21659#issuecomment-1044581829
> OK, I knew Airflow was good about pinning and updates, just wanted to make sure I understood. Thanks!
You are welcome, BTW. Here is a talk I gave about managing dependencies at Airlfow :) https://www.youtube.com/watch?v=_SjMdQLP30s&t=2553s if you build some weekend watchlist and learn more on how we do it :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jedcunningham merged pull request #21659: Sync `v2-2-stable` with `v2-2-test` to release `2.2.4`
Posted by GitBox <gi...@apache.org>.
jedcunningham merged pull request #21659:
URL: https://github.com/apache/airflow/pull/21659
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #21659: Sync `v2-2-stable` with `v2-2-test` to release `2.2.4`
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #21659:
URL: https://github.com/apache/airflow/pull/21659#issuecomment-1044572024
> Pinning to MarkupSafe<2.1 or Jinja<3 should only be short term fixes, neither version range is supported.
Yep it is short term - see the comment. But For 2.2.4 it is safe bet. 2.2.5 or 2.3.0 shoudl have it lifted providing that we fix it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #21659: Sync `v2-2-stable` with `v2-2-test` to release `2.2.4`
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #21659:
URL: https://github.com/apache/airflow/pull/21659#issuecomment-1044408352
I want to add one more to that though. Today we saw the markupsafe 2.1.0 breaking our main build due to https://github.com/pallets/markupsafe/issues/284 - and while our constraints prevent us from those errors, explicitly pinning markupseafe to < 2.1.0 is a good thing to do now as this is a "known and documented" problem.
The change is here : https://github.com/apache/airflow/pull/21664 - just a setup.cfg change. I will cherry-pick it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org