[GitHub] apeforest commented on a change in pull request #11742: [MXNET-623][WIP] Fixing an integer overflow bug in large NDArray

[GitBox <gi...@apache.org>]

apeforest commented on a change in pull request #11742: [MXNET-623][WIP] Fixing an integer overflow bug in large NDArray
URL: https://github.com/apache/incubator-mxnet/pull/11742#discussion_r217121905
 
 

 ##########
 File path: src/c_api/c_api_function.cc
 ##########
 @@ -56,7 +56,7 @@ std::vector<nnvm::NodeEntry> Gradient(
 
   std::vector<nnvm::NodeEntry> ret;
   for (index_t i = 0; i < g->num_outputs(); ++i) {
-    ret.emplace_back(nnvm::NodeEntry{g, i, 0});
+    ret.emplace_back(nnvm::NodeEntry{g, static_cast<uint32_t>(i), 0});
 
 Review comment:
   The Node data structure in nnvm::Graph uses uint32_t to index graph nodes. In that case, the number of nodes in the graph is not going to be greater than 2^32. I have communicated this to the tvm team and they suggest we keep the uint32_t for node id.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services