You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Andrew Onischuk <ao...@hortonworks.com> on 2014/02/17 13:34:31 UTC

Review Request 18189: Deprecation warnings show up in stderr because of using sets in Ganglia

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18189/
-----------------------------------------------------------

Review request for Ambari and Arsen Babych.


Bugs: AMBARI-4696
    https://issues.apache.org/jira/browse/AMBARI-4696


Repository: ambari


Description
-------

{code}
/var/lib/ambari-agent/cache/stacks/HDP/2.0.6/services/GANGLIA/package/scripts/params.py:21: DeprecationWarning: the sets module is deprecated
  from sets import Set

{code}

Since these are user visible logs - lets fix these - either use something else instead of sets or mask the deprecation.


Diffs
-----

  ambari-server/src/main/resources/stacks/HDP/1.3.2/services/GANGLIA/package/scripts/params.py f9c90c5 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/GANGLIA/package/scripts/params.py 434c59c 

Diff: https://reviews.apache.org/r/18189/diff/


Testing
-------


Thanks,

Andrew Onischuk


Re: Review Request 18189: Deprecation warnings show up in stderr because of using sets in Ganglia

Posted by Arsen Babych <ab...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18189/#review34644
-----------------------------------------------------------

Ship it!


Ship It!

- Arsen Babych


On Feb. 17, 2014, 12:34 p.m., Andrew Onischuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18189/
> -----------------------------------------------------------
> 
> (Updated Feb. 17, 2014, 12:34 p.m.)
> 
> 
> Review request for Ambari and Arsen Babych.
> 
> 
> Bugs: AMBARI-4696
>     https://issues.apache.org/jira/browse/AMBARI-4696
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> {code}
> /var/lib/ambari-agent/cache/stacks/HDP/2.0.6/services/GANGLIA/package/scripts/params.py:21: DeprecationWarning: the sets module is deprecated
>   from sets import Set
> 
> {code}
> 
> Since these are user visible logs - lets fix these - either use something else instead of sets or mask the deprecation.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/stacks/HDP/1.3.2/services/GANGLIA/package/scripts/params.py f9c90c5 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/GANGLIA/package/scripts/params.py 434c59c 
> 
> Diff: https://reviews.apache.org/r/18189/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>