You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Kengo Seki (JIRA)" <ji...@apache.org> on 2015/05/22 02:06:17 UTC

[jira] [Commented] (HADOOP-11994) smart-apply-patch wrongly assumes that git is infallible

    [ https://issues.apache.org/jira/browse/HADOOP-11994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14555322#comment-14555322 ] 

Kengo Seki commented on HADOOP-11994:
-------------------------------------

[~aw], smart-apply-patch seems to use the normal patch command rather than git apply. And on HADOOP-12014, smart-apply-patch failed but git apply succeeded.
What you meant is, if patch command fails, then try git apply?


> smart-apply-patch wrongly assumes that git is infallible
> --------------------------------------------------------
>
>                 Key: HADOOP-11994
>                 URL: https://issues.apache.org/jira/browse/HADOOP-11994
>             Project: Hadoop Common
>          Issue Type: Bug
>            Reporter: Allen Wittenauer
>
> Even if git fails, smart-apply-patch should try the normal patch command.  I've seen a few patches now where git apply fails, but patch does not.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)