[GitHub] [skywalking] kezhenxu94 opened a new pull request #2846: Add config to control tracing sql parameters in MySQL agent

[GitBox <gi...@apache.org>]

kezhenxu94 opened a new pull request #2846: Add config to control tracing sql parameters in MySQL agent
URL: https://github.com/apache/skywalking/pull/2846
 
 
   Please answer these questions before submitting pull request
   
   - Why submit this pull request?
   - [ ] Bug fix
   - [x] New feature provided
   - [ ] Improve performance
   
   - Related issues
   resolves #2587 
   
   ___
   ### New feature or improvement
   
   - Describe the details and related test reports.
   
   Add a config key to control whether to collect the SQL parameters.
   
   Here is one point need to discuss:
   
   there're methods like `java.sql.PreparedStatement#setBinaryStream(int, java.io.InputStream, long)`, `java.sql.PreparedStatement#setBlob(int, java.io.InputStream, long)` and similar methods in `PreparedStatement`, should we collect them as well? The `InputStream` may be large and hard to represent in tags, I would like to only collect their length and represent as something like `InputStream[120]` or better idea?
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services