You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2021/05/31 12:37:10 UTC

[GitHub] [rocketmq] zourunxin commented on a change in pull request #2919: [ISSUE #2918]Remove useless code

zourunxin commented on a change in pull request #2919:
URL: https://github.com/apache/rocketmq/pull/2919#discussion_r642456943



##########
File path: store/src/main/java/org/apache/rocketmq/store/index/IndexFile.java
##########
@@ -95,12 +95,8 @@ public boolean putKey(final String key, final long phyOffset, final long storeTi
             int slotPos = keyHash % this.hashSlotNum;
             int absSlotPos = IndexHeader.INDEX_HEADER_SIZE + slotPos * hashSlotSize;
 
-            FileLock fileLock = null;
-

Review comment:
       this is correct, as the fileLock has not been used except finally(at 147row




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org