You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "alamb (via GitHub)" <gi...@apache.org> on 2023/03/20 11:12:13 UTC

[GitHub] [arrow-datafusion] alamb commented on issue #5645: Move the file `/expr/src/type_coercion.rs` to the directory `/expr/src/type_coercion/` and rename it `mod`.

alamb commented on issue #5645:
URL: https://github.com/apache/arrow-datafusion/issues/5645#issuecomment-1476037848

   > Hi @alamb is there any background why we have same named directory and file under a path?
   > I find we have the same named things for both type_coercion and expr_rewriter .
   
   I don't think there is any reason  other than Rust allows for either.
   
   Typically I think the file exists first (`type_coercion.rs`) and then when submodules are made it isn't renamed to mod.rs 
   
   It would be great to get DataFusion consistent in this regard (use `mod.rs`) 👍 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org