You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/04/14 17:37:49 UTC

[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #2231: chore: add debug log

alamb commented on code in PR #2231:
URL: https://github.com/apache/arrow-datafusion/pull/2231#discussion_r850662282


##########
datafusion/core/src/physical_plan/filter.rs:
##########
@@ -133,8 +134,8 @@ impl ExecutionPlan for FilterExec {
         partition: usize,
         context: Arc<TaskContext>,
     ) -> Result<SendableRecordBatchStream> {
+        debug!("Start FilterExec::execute for partition: {}", partition);

Review Comment:
   I wonder if it would be useful to log `context` as well (perhaps `session_id` and `task_id`)?
   
   https://github.com/apache/arrow-datafusion/blob/7a6317a0e31829ab06669a57987272b97e4694f4/datafusion/core/src/execution/context.rs#L1430
   
   This comment applies to this entire PR



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org