You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "CurtHagenlocher (via GitHub)" <gi...@apache.org> on 2023/07/17 19:25:26 UTC

[GitHub] [arrow] CurtHagenlocher commented on a diff in pull request #35716: GH-33032: [C#] Support fixed-size lists

CurtHagenlocher commented on code in PR #35716:
URL: https://github.com/apache/arrow/pull/35716#discussion_r1265807203


##########
csharp/src/Apache.Arrow/Field.cs:
##########
@@ -35,24 +35,24 @@ public partial class Field
 
         public Field(string name, IArrowType dataType, bool nullable,
             IEnumerable<KeyValuePair<string, string>> metadata = default)
-            : this(name, dataType, nullable)
+            : this(name, dataType, nullable, false)
         {
             Metadata = metadata?.ToDictionary(kv => kv.Key, kv => kv.Value);
 
         }
 
         internal Field(string name, IArrowType dataType, bool nullable,
-            IReadOnlyDictionary<string, string> metadata, bool copyCollections)
-            : this(name, dataType, nullable)
+            IReadOnlyDictionary<string, string> metadata, bool copyCollections, bool allowBlankName)
+            : this(name, dataType, nullable, allowBlankName)
         {
             Debug.Assert(copyCollections == false, "This internal constructor is to not copy the collections.");
 
             Metadata = metadata;
         }
 
-        private Field(string name, IArrowType dataType, bool nullable)
+        private Field(string name, IArrowType dataType, bool nullable, bool allowBlankName)

Review Comment:
   Though perhaps this should be done more broadly as per #36588.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org