You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by "Ralf S. Engelschall" <rs...@engelschall.com> on 1997/03/10 11:17:41 UTC

[PATCH] modules/Makefile

While building an 1.2b7 with mod_perl and mod_proxy I discovered a little
problem with modules/Makefile.  The AUX_CFLAGS data is correctly sourrounded
by '' in the top level Makefile. But in modules/Makefile it is surrounded with
"". This leads to a compilation break when something like
SUBSERVER_VERSION=\"...\" is used because then the backslashed are missing in
the make process below!

The following patch corrects this:

*** modules/Makefile.orig   Mon Mar 10 11:14:17 1997
--- modules/Makefile    Mon Mar 10 11:13:09 1997
***************
*** 59,63 ****
    (for dir in $(MODULES); do \
        cd $$dir; \
!       $(MAKE) CC=$(CC) AUX_CFLAGS="$(AUX_CFLAGS)" RANLIB="$(RANLIB)"; \
        cd ..; \
    done)
--- 59,63 ----
    (for dir in $(MODULES); do \
        cd $$dir; \
!       $(MAKE) CC=$(CC) AUX_CFLAGS='$(AUX_CFLAGS)' RANLIB="$(RANLIB)"; \
        cd ..; \
    done)

Greetings,
                                       Ralf S. Engelschall
                                       rse@engelschall.com
                                       www.engelschall.com

Re: [PATCH] modules/Makefile

Posted by Chuck Murcko <ch...@topsail.org>.
I believe this is covered in Ken's patch, so we would not need this one
if it goes in.

Ralf S. Engelschall wrote:
> 
> While building an 1.2b7 with mod_perl and mod_proxy I discovered a little
> problem with modules/Makefile.  The AUX_CFLAGS data is correctly sourrounded
> by '' in the top level Makefile. But in modules/Makefile it is surrounded with
> "". This leads to a compilation break when something like
> SUBSERVER_VERSION=\"...\" is used because then the backslashed are missing in
> the make process below!
> 
> The following patch corrects this:
> 
> *** modules/Makefile.orig   Mon Mar 10 11:14:17 1997
> --- modules/Makefile    Mon Mar 10 11:13:09 1997
> ***************
> *** 59,63 ****
>     (for dir in $(MODULES); do \
>         cd $$dir; \
> !       $(MAKE) CC=$(CC) AUX_CFLAGS="$(AUX_CFLAGS)" RANLIB="$(RANLIB)"; \
>         cd ..; \
>     done)
> --- 59,63 ----
>     (for dir in $(MODULES); do \
>         cd $$dir; \
> !       $(MAKE) CC=$(CC) AUX_CFLAGS='$(AUX_CFLAGS)' RANLIB="$(RANLIB)"; \
>         cd ..; \
>     done)
> 
> Greetings,
>                                        Ralf S. Engelschall
>                                        rse@engelschall.com
>                                        www.engelschall.com

-- 
chuck
Chuck Murcko
The Topsail Group, West Chester PA USA
chuck@topsail.org