[GitHub] [pulsar] Jason918 commented on a diff in pull request #15099: [cleanup][broker] PIP 45: Deprecate zookeeper settings

[GitBox <gi...@apache.org>]

Jason918 commented on code in PR #15099:
URL: https://github.com/apache/pulsar/pull/15099#discussion_r846912037


##########
conf/broker.conf:
##########
@@ -1016,9 +1016,15 @@ managedLedgerCursorRolloverTimeInSeconds=14400
 # crashes.
 managedLedgerMaxUnackedRangesToPersist=10000
 
+# Max number of "acknowledgment holes" that can be stored in MetadataStore. If number of unack message range is higher
+# than this limit then broker will persist unacked ranges into bookkeeper to avoid additional data overhead into
+# MetadataStore.
+managedLedgerMaxUnackedRangesToPersistInMetadataStore=1000
+
 # Max number of "acknowledgment holes" that can be stored in Zookeeper. If number of unack message range is higher
 # than this limit then broker will persist unacked ranges into bookkeeper to avoid additional data overhead into
 # zookeeper.
+# Deprecated: use metadataStoreSessionTimeoutMillis

Review Comment:
   Please move this to the bottom of the file.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org