You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Ramesh Mani <rm...@hortonworks.com> on 2016/10/19 20:40:38 UTC
Review Request 53032: RANGER-1189: Enhance and provide APIs to
getAllpolicies with different filter options
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53032/
-----------------------------------------------------------
Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.
Repository: ranger
Description
-------
RANGER-1189: Enhance and provide APIs to getAllpolicies with different filter options
Diffs
-----
security-admin/src/main/java/org/apache/ranger/rest/PublicAPIsv2.java cb50c9f
security-admin/src/test/java/org/apache/ranger/rest/TestPublicAPIsv2.java 1404637
Diff: https://reviews.apache.org/r/53032/diff/
Testing
-------
Testing done with internal VM.
Thanks,
Ramesh Mani
Re: Review Request 53032: RANGER-1189: Enhance and provide APIs to
getAllpolicies with different filter options
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53032/#review153423
-----------------------------------------------------------
Fix it, then Ship it!
security-admin/src/main/java/org/apache/ranger/rest/PublicAPIsv2.java (line 296)
<https://reviews.apache.org/r/53032/#comment222726>
Having no policies may not be an error condition. Consider returning an empty list in this case.
- Madhan Neethiraj
On Oct. 20, 2016, 12:55 a.m., Ramesh Mani wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53032/
> -----------------------------------------------------------
>
> (Updated Oct. 20, 2016, 12:55 a.m.)
>
>
> Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.
>
>
> Repository: ranger
>
>
> Description
> -------
>
> RANGER-1189: Enhance and provide APIs to getAllpolicies with different filter options
>
>
> Diffs
> -----
>
> security-admin/src/main/java/org/apache/ranger/rest/PublicAPIsv2.java cb50c9f
> security-admin/src/test/java/org/apache/ranger/rest/TestPublicAPIsv2.java 1404637
>
> Diff: https://reviews.apache.org/r/53032/diff/
>
>
> Testing
> -------
>
> Testing done with internal VM.
>
>
> Thanks,
>
> Ramesh Mani
>
>
Re: Review Request 53032: RANGER-1189: Enhance and provide APIs to
getAllpolicies with different filter options
Posted by Ramesh Mani <rm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53032/
-----------------------------------------------------------
(Updated Oct. 20, 2016, 12:55 a.m.)
Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.
Changes
-------
Correct the API to use ServiceREST instead of direct fetching use searchfilter.
Repository: ranger
Description
-------
RANGER-1189: Enhance and provide APIs to getAllpolicies with different filter options
Diffs (updated)
-----
security-admin/src/main/java/org/apache/ranger/rest/PublicAPIsv2.java cb50c9f
security-admin/src/test/java/org/apache/ranger/rest/TestPublicAPIsv2.java 1404637
Diff: https://reviews.apache.org/r/53032/diff/
Testing
-------
Testing done with internal VM.
Thanks,
Ramesh Mani
Re: Review Request 53032: RANGER-1189: Enhance and provide APIs to
getAllpolicies with different filter options
Posted by Ramesh Mani <rm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53032/
-----------------------------------------------------------
(Updated Oct. 19, 2016, 9:27 p.m.)
Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.
Repository: ranger
Description
-------
RANGER-1189: Enhance and provide APIs to getAllpolicies with different filter options
Diffs
-----
security-admin/src/main/java/org/apache/ranger/rest/PublicAPIsv2.java cb50c9f
security-admin/src/test/java/org/apache/ranger/rest/TestPublicAPIsv2.java 1404637
Diff: https://reviews.apache.org/r/53032/diff/
Testing
-------
Testing done with internal VM.
Thanks,
Ramesh Mani