[GitHub] [hbase] petersomogyi commented on a diff in pull request #4773: HBASE-27317 : Storefiletracking : Rectifying the option for columnfamily as mandatory

[GitBox <gi...@apache.org>]

petersomogyi commented on code in PR #4773:
URL: https://github.com/apache/hbase/pull/4773#discussion_r969668479


##########
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/storefiletracker/StoreFileListFilePrettyPrinter.java:
##########
@@ -96,9 +99,7 @@ private void init() {
   public boolean parseOptions(String[] args) throws ParseException, IOException {
     HelpFormatter formatter = new HelpFormatter();
     if (args.length == 0) {
-      formatter
-        .printHelp("sft [--file=</path/to/tracker/file> | --table=<namespace:tablename|tablename>"
-          + " --region=<regionname> [--columnFamily=<columnfamily>] ]", options, true);
+      formatter.printHelp(helpMsg, options, true);

Review Comment:
   The `printHelp` expects the command name as the first parameter and will generate the help message based on the passed Options. You don't need to include the parameters in the `cmdLineSyntax`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org