You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/02/06 18:07:22 UTC
[GitHub] codecov-io commented on issue #6802: Removing additional unguarded
calls to JSON.stringify
codecov-io commented on issue #6802: Removing additional unguarded calls to JSON.stringify
URL: https://github.com/apache/incubator-superset/pull/6802#issuecomment-461125595
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/6802?src=pr&el=h1) Report
> Merging [#6802](https://codecov.io/gh/apache/incubator-superset/pull/6802?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/5669a823508b317648ccbca4de62fbd4e8420a98?src=pr&el=desc) will **increase** coverage by `0.09%`.
> The diff coverage is `50%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/6802/graphs/tree.svg?width=650&token=KsB0fHcx6l&height=150&src=pr)](https://codecov.io/gh/apache/incubator-superset/pull/6802?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6802 +/- ##
==========================================
+ Coverage 56.07% 56.16% +0.09%
==========================================
Files 526 527 +1
Lines 23253 23377 +124
Branches 2783 2794 +11
==========================================
+ Hits 13038 13130 +92
- Misses 9806 9837 +31
- Partials 409 410 +1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/6802?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...rset/assets/src/dashboard/components/SaveModal.jsx](https://codecov.io/gh/apache/incubator-superset/pull/6802/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvY29tcG9uZW50cy9TYXZlTW9kYWwuanN4) | `46.15% <ø> (ø)` | :arrow_up: |
| [.../src/visualizations/core/components/SuperChart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/6802/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy92aXN1YWxpemF0aW9ucy9jb3JlL2NvbXBvbmVudHMvU3VwZXJDaGFydC5qc3g=) | `10.2% <ø> (ø)` | :arrow_up: |
| [...uperset/assets/src/dashboard/components/Header.jsx](https://codecov.io/gh/apache/incubator-superset/pull/6802/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvY29tcG9uZW50cy9IZWFkZXIuanN4) | `41.11% <0%> (ø)` | :arrow_up: |
| [superset/assets/src/visualizations/Rose/Rose.js](https://codecov.io/gh/apache/incubator-superset/pull/6802/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy92aXN1YWxpemF0aW9ucy9Sb3NlL1Jvc2UuanM=) | `0% <0%> (ø)` | :arrow_up: |
| [superset/assets/src/components/AlteredSliceTag.jsx](https://codecov.io/gh/apache/incubator-superset/pull/6802/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9jb21wb25lbnRzL0FsdGVyZWRTbGljZVRhZy5qc3g=) | `98.66% <100%> (ø)` | :arrow_up: |
| [superset/assets/src/explore/exploreUtils.js](https://codecov.io/gh/apache/incubator-superset/pull/6802/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9leHBsb3JlL2V4cGxvcmVVdGlscy5qcw==) | `80.85% <50%> (ø)` | :arrow_up: |
| [superset/assets/src/components/TableSelector.jsx](https://codecov.io/gh/apache/incubator-superset/pull/6802/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9jb21wb25lbnRzL1RhYmxlU2VsZWN0b3IuanN4) | `83.33% <0%> (-0.41%)` | :arrow_down: |
| [superset/assets/src/explore/controls.jsx](https://codecov.io/gh/apache/incubator-superset/pull/6802/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9leHBsb3JlL2NvbnRyb2xzLmpzeA==) | `42.4% <0%> (-0.35%)` | :arrow_down: |
| [superset/db\_engine\_specs.py](https://codecov.io/gh/apache/incubator-superset/pull/6802/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzLnB5) | `53.82% <0%> (-0.29%)` | :arrow_down: |
| [superset/sql\_parse.py](https://codecov.io/gh/apache/incubator-superset/pull/6802/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3BhcnNlLnB5) | `99.15% <0%> (-0.05%)` | :arrow_down: |
| ... and [11 more](https://codecov.io/gh/apache/incubator-superset/pull/6802/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/6802?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/6802?src=pr&el=footer). Last update [5669a82...3f7164f](https://codecov.io/gh/apache/incubator-superset/pull/6802?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org