[jira] Resolved: (MYFACES-2144) parsing problem

["Bernd Bohmann (JIRA)" <de...@myfaces.apache.org>]

     [ https://issues.apache.org/jira/browse/MYFACES-2144?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bernd Bohmann resolved MYFACES-2144.
------------------------------------

    Resolution: Fixed

Thanks for the patch

> <render-kit> parsing problem
> ----------------------------
>
>                 Key: MYFACES-2144
>                 URL: https://issues.apache.org/jira/browse/MYFACES-2144
>             Project: MyFaces Core
>          Issue Type: Bug
>    Affects Versions: 1.2.7-SNAPSHOT
>            Reporter: Val Blant
>            Assignee: Bernd Bohmann
>             Fix For: 1.2.7-SNAPSHOT, 2.0.0-alpha
>
>         Attachments: MYFACES-2144.patch
>
>
> There is a small error in DigesterFacesConfigDispenserImpl.feed() method. 
> In the for-loop responsible for storing the render kits, when no render kit id was specified in the file being parsed (i.e. renderKit.getId() is null), we default the render kit id to "HTML_BASIC". Later we store the render kit in a map (renderKits), with key being the render kit id. However, the code erroneously uses null as the key, instead of  "HTML_BASIC". This, of course, breaks FacesConfigurator.configureRenderKits() once it tries to add a render kit with a 'null' id.
> I suspect that the reason for this bug going unnoticed until now is that the 'null' key will only be used if the FIRST <render-kit> found on the class path does not specify an explicit id. All subsequent <render-kit> declarations are merged into the element with the correct key (HTML_BASIC), which is why it works as long as the first <render-kit> has an id. 
> I'm uploading a patch with a fix for this bug.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.