You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Bryan Duxbury (JIRA)" <ji...@apache.org> on 2008/08/20 21:40:44 UTC
[jira] Created: (THRIFT-117) FramedTransport should support borrow
so it can be used with BinaryProtocolAccelerated
FramedTransport should support borrow so it can be used with BinaryProtocolAccelerated
--------------------------------------------------------------------------------------
Key: THRIFT-117
URL: https://issues.apache.org/jira/browse/THRIFT-117
Project: Thrift
Issue Type: New Feature
Components: Library (Ruby)
Reporter: Bryan Duxbury
FramedTransport should have a borrow() (and of course consume!) implementation so that it can be used with BinaryProtocolAccelerated.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-117) FramedTransport should support borrow
so it can be used with BinaryProtocolAccelerated
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-117?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryan Duxbury updated THRIFT-117:
---------------------------------
Attachment: thrift-117-v2.patch
Here's a version with a spec.
> FramedTransport should support borrow so it can be used with BinaryProtocolAccelerated
> --------------------------------------------------------------------------------------
>
> Key: THRIFT-117
> URL: https://issues.apache.org/jira/browse/THRIFT-117
> Project: Thrift
> Issue Type: New Feature
> Components: Library (Ruby)
> Reporter: Bryan Duxbury
> Assignee: Bryan Duxbury
> Attachments: thrift-117-v2.patch, thrift-117.patch
>
>
> FramedTransport should have a borrow() (and of course consume!) implementation so that it can be used with BinaryProtocolAccelerated.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-117) FramedTransport should support borrow
so it can be used with BinaryProtocolAccelerated
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-117?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryan Duxbury updated THRIFT-117:
---------------------------------
Assignee: Bryan Duxbury
Patch Info: [Patch Available]
> FramedTransport should support borrow so it can be used with BinaryProtocolAccelerated
> --------------------------------------------------------------------------------------
>
> Key: THRIFT-117
> URL: https://issues.apache.org/jira/browse/THRIFT-117
> Project: Thrift
> Issue Type: New Feature
> Components: Library (Ruby)
> Reporter: Bryan Duxbury
> Assignee: Bryan Duxbury
> Attachments: thrift-117.patch
>
>
> FramedTransport should have a borrow() (and of course consume!) implementation so that it can be used with BinaryProtocolAccelerated.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-117) FramedTransport should support borrow
so it can be used with BinaryProtocolAccelerated
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-117?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryan Duxbury updated THRIFT-117:
---------------------------------
Attachment: thrift-117.patch
Here's a patch that adds this functionality.
> FramedTransport should support borrow so it can be used with BinaryProtocolAccelerated
> --------------------------------------------------------------------------------------
>
> Key: THRIFT-117
> URL: https://issues.apache.org/jira/browse/THRIFT-117
> Project: Thrift
> Issue Type: New Feature
> Components: Library (Ruby)
> Reporter: Bryan Duxbury
> Attachments: thrift-117.patch
>
>
> FramedTransport should have a borrow() (and of course consume!) implementation so that it can be used with BinaryProtocolAccelerated.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (THRIFT-117) FramedTransport should support borrow
so it can be used with BinaryProtocolAccelerated
Posted by "Kevin Clark (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-117?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kevin Clark closed THRIFT-117.
------------------------------
Resolution: Fixed
Wonderful.
Pushed in 688901.
> FramedTransport should support borrow so it can be used with BinaryProtocolAccelerated
> --------------------------------------------------------------------------------------
>
> Key: THRIFT-117
> URL: https://issues.apache.org/jira/browse/THRIFT-117
> Project: Thrift
> Issue Type: New Feature
> Components: Library (Ruby)
> Reporter: Bryan Duxbury
> Assignee: Bryan Duxbury
> Attachments: thrift-117-v2.patch, thrift-117.patch
>
>
> FramedTransport should have a borrow() (and of course consume!) implementation so that it can be used with BinaryProtocolAccelerated.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-117) FramedTransport should support
borrow so it can be used with BinaryProtocolAccelerated
Posted by "Kevin Clark (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12624193#action_12624193 ]
Kevin Clark commented on THRIFT-117:
------------------------------------
Yeah, looks like it was never added (grr at myself). I'd expect a test for borrow to cover the cases we've talked about. When it has a buffer, and you ask for less that than amount, it returns atleast the right amount. If you ask for an amount, and you don't have it, it calls out to refill somehow. If it can't refill, it errors appropriately. That sort of thing.
> FramedTransport should support borrow so it can be used with BinaryProtocolAccelerated
> --------------------------------------------------------------------------------------
>
> Key: THRIFT-117
> URL: https://issues.apache.org/jira/browse/THRIFT-117
> Project: Thrift
> Issue Type: New Feature
> Components: Library (Ruby)
> Reporter: Bryan Duxbury
> Assignee: Bryan Duxbury
> Attachments: thrift-117.patch
>
>
> FramedTransport should have a borrow() (and of course consume!) implementation so that it can be used with BinaryProtocolAccelerated.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-117) FramedTransport should support
borrow so it can be used with BinaryProtocolAccelerated
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12624180#action_12624180 ]
Bryan Duxbury commented on THRIFT-117:
--------------------------------------
What would an appropriate test look like? I don't recall seeing a test for BufferedTransport's borrow method, but I could have missed it.
> FramedTransport should support borrow so it can be used with BinaryProtocolAccelerated
> --------------------------------------------------------------------------------------
>
> Key: THRIFT-117
> URL: https://issues.apache.org/jira/browse/THRIFT-117
> Project: Thrift
> Issue Type: New Feature
> Components: Library (Ruby)
> Reporter: Bryan Duxbury
> Assignee: Bryan Duxbury
> Attachments: thrift-117.patch
>
>
> FramedTransport should have a borrow() (and of course consume!) implementation so that it can be used with BinaryProtocolAccelerated.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-117) FramedTransport should support
borrow so it can be used with BinaryProtocolAccelerated
Posted by "Kevin Clark (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12624179#action_12624179 ]
Kevin Clark commented on THRIFT-117:
------------------------------------
This looks fine, can you attach a test as well?
> FramedTransport should support borrow so it can be used with BinaryProtocolAccelerated
> --------------------------------------------------------------------------------------
>
> Key: THRIFT-117
> URL: https://issues.apache.org/jira/browse/THRIFT-117
> Project: Thrift
> Issue Type: New Feature
> Components: Library (Ruby)
> Reporter: Bryan Duxbury
> Assignee: Bryan Duxbury
> Attachments: thrift-117.patch
>
>
> FramedTransport should have a borrow() (and of course consume!) implementation so that it can be used with BinaryProtocolAccelerated.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.