You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@spamassassin.apache.org by bu...@bugzilla.spamassassin.org on 2010/02/09 19:25:05 UTC
[Bug 6327] New: Fix calling argument in utility used to determine
DCC's homedir
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6327
Summary: Fix calling argument in utility used to determine
DCC's homedir
Product: Spamassassin
Version: 3.3.0
Platform: Other
OS/Version: All
Status: NEW
Severity: minor
Priority: P5
Component: Plugins
AssignedTo: dev@spamassassin.apache.org
ReportedBy: cgreen@sentex.net
Created an attachment (id=4668)
--> (https://issues.apache.org/SpamAssassin/attachment.cgi?id=4668)
Patch to DCC.pm to change the argument cdcc is called with
SpamAssassin's DCC.pm uses the cdcc utility to find DCC's home directory,
calling it with 'cdcc home'. Apparently, the official argument cdcc uses is
'homedir', however. While 'home' worked in previous DCC versions:
cgreen:Pumice7# cdcc -V
1.3.105
cdcc map> ^C
cgreen:Pumice7# cdcc home
homedir=/var/dcc
cgreen:Pumice7# cdcc homedir
homedir=/var/dcc
the usage has been tightened up in more recent ones:
cgreen:Test_releng8# cdcc -V
1.3.116
cdcc map> ^C
cgreen:Test_releng8# cdcc home
usage: homedir [path]
?
cgreen:Test_releng8# cdcc homedir
homedir=/var/dcc
This is also seen in SA 3.3.0's debugging output:
cgreen:Test_releng8# spamassassin -V
SpamAssassin version 3.3.0
running on Perl version 5.10.1
cgreen:Test_releng8# spamassassin -Ddcc < /tmp/1
Feb 9 12:37:39.250 [25567] dbg: dcc: network tests on, registering DCC
Feb 9 12:37:43.303 [25567] dbg: dcc: dcc_home not set, querying cdcc utility
Feb 9 12:37:43.315 [25567] dbg: dcc: cdcc reports homedir as ' ?'
Simply patching DCC.pm to use 'cdcc homedir' instead fixes the issue:
cgreen:Test_releng8# spamassassin -Ddcc < /tmp/1
Feb 9 12:46:55.594 [25682] dbg: dcc: network tests on, registering DCC
Feb 9 12:46:59.081 [25682] dbg: dcc: dcc_home not set, querying cdcc utility
Feb 9 12:46:59.092 [25682] dbg: dcc: cdcc reports homedir as '/var/dcc'
Feb 9 12:46:59.094 [25682] dbg: dcc: cdcc reported homedir /var/dcc exists,
using it
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6327] [review] Fix calling argument in utility used to
determine DCC's homedir
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6327
Mark Martinec <Ma...@ijs.si> changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|Fix calling argument in |[review] Fix calling
|utility used to determine |argument in utility used to
|DCC's homedir |determine DCC's homedir
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6327] [review] Fix calling argument in utility used to
determine DCC's homedir
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6327
Mark Martinec <Ma...@ijs.si> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |FIXED
--- Comment #4 from Mark Martinec <Ma...@ijs.si> 2010-02-10 17:27:30 UTC ---
3.3:
Bug 6327: Fix calling argument in utility used to determine DCC's homedir
Sending lib/Mail/SpamAssassin/Plugin/DCC.pm
Committed revision 908595.
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6327] [review] Fix calling argument in utility used to
determine DCC's homedir
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6327
Kevin A. McGrail <km...@pccc.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |kmcgrail@pccc.com
Status Whiteboard|needs 1 vote |ready to commit
--- Comment #3 from Kevin A. McGrail <km...@pccc.com> 2010-02-10 17:15:13 UTC ---
(In reply to comment #2)
> +1
+1
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6327] Fix calling argument in utility used to determine DCC's
homedir
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6327
Mark Martinec <Ma...@ijs.si> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status Whiteboard| |needs 2 votes
--- Comment #1 from Mark Martinec <Ma...@ijs.si> 2010-02-10 06:41:42 UTC ---
> the official argument cdcc uses is 'homedir'
Indeed. The 'home' is nowhere documented.
> Created an attachment (id=4668)
--> (https://issues.apache.org/SpamAssassin/attachment.cgi?id=4668) [details]
> Patch to DCC.pm to change the argument cdcc is called with
+1 for inclusion in 3.3.1
trunk:
Sending lib/Mail/SpamAssassin/Plugin/DCC.pm
Committed revision 908518.
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6327] [review] Fix calling argument in utility used to
determine DCC's homedir
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6327
Mark Martinec <Ma...@ijs.si> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status Whiteboard|needs 2 votes |needs 1 vote
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6327] Fix calling argument in utility used to determine DCC's
homedir
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6327
Mark Martinec <Ma...@ijs.si> changed:
What |Removed |Added
----------------------------------------------------------------------------
Priority|P5 |P3
Target Milestone|Undefined |3.3.1
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6327] [review] Fix calling argument in utility used to
determine DCC's homedir
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6327
Justin Mason <jm...@jmason.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jm@jmason.org
--- Comment #2 from Justin Mason <jm...@jmason.org> 2010-02-10 16:45:09 UTC ---
+1
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.