You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/05/31 11:52:30 UTC

[GitHub] [arrow-rs] alamb commented on a diff in pull request #1767: Remove `validate_decimal_precision` check in `DecimalBuilder.append_value`

alamb commented on code in PR #1767:
URL: https://github.com/apache/arrow-rs/pull/1767#discussion_r885540606


##########
arrow/src/array/array_binary.rs:
##########
@@ -1497,38 +1497,6 @@ mod tests {
         assert_eq!(16, decimal_array.value_length());
     }
 
-    #[test]
-    fn test_decimal_append_error_value() {

Review Comment:
   I recommend we change this test to show that it is ok to store these values in a decimal rather than removing it completely (aka change the test to validate there is no error).
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org