[GitHub] [pulsar] merlimat commented on a change in pull request #4475: [issues 4464] Fix batch logic and add test case

[GitBox <gi...@apache.org>]

merlimat commented on a change in pull request #4475: [issues 4464] Fix batch logic and add test case
URL: https://github.com/apache/pulsar/pull/4475#discussion_r290827018
 
 

 ##########
 File path: pulsar-client-go/pulsar/c_producer.go
 ##########
 @@ -156,9 +156,7 @@ func createProducerAsync(client *client, schema Schema, options ProducerOptions,
 		C._pulsar_producer_configuration_set_message_router(conf, savePointer(&options.MessageRouter))
 	}
 
-	if options.Batching {
-		C.pulsar_producer_configuration_set_batching_enabled(conf, cBool(options.Batching))
-	}
+	C.pulsar_producer_configuration_set_batching_enabled(conf, cBool(options.Batching))
 
 Review comment:
   The downside for this is that batching will be disabled by default on Go (unless we make the flag to be a pointer), because there's no way to set `Batching = true` by default. 
   
   This is something we can fix with the API beak in the native go client.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services