You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@nifi.apache.org by ravib777 <gi...@git.apache.org> on 2018/11/07 07:27:39 UTC

[GitHub] nifi pull request #3137: NIFI-5797 : EscapedJava for FlattenJson

GitHub user ravib777 opened a pull request:

    https://github.com/apache/nifi/pull/3137

    NIFI-5797 : EscapedJava for FlattenJson

    Thank you for submitting a contribution to Apache NiFi.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [ ] Is there a JIRA ticket associated with this PR? Is it referenced 
         in the commit message?
    
    - [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    
    - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    - [ ] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
    - [ ] Have you written or updated unit tests to verify your changes?
    - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? 
    - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
    - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
    - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
    
    ### For documentation related changes:
    - [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ravib777/nifi NIFI-5797-FlattenJson-Special-Chars-Doesnt-work

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/3137.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3137
    
----
commit c1c1ef41e541601d913fcda68212a4cff12818cd
Author: Ravi Bhardwaj <ra...@...>
Date:   2018-11-07T07:24:12Z

    NIFI-5797 : EscapedJava for FlattenJson

----


---

[GitHub] nifi issue #3137: NIFI-5797 : EscapedJava for FlattenJson

Posted by alopresto <gi...@git.apache.org>.

Github user alopresto commented on the issue:

    https://github.com/apache/nifi/pull/3137
  
    Can you please add some explanation for why this change is submitted, documentation, and at least one unit test? Thank you. 


---

[GitHub] nifi issue #3137: NIFI-5797 : EscapedJava for FlattenJson

Posted by pvillard31 <gi...@git.apache.org>.

Github user pvillard31 commented on the issue:

    https://github.com/apache/nifi/pull/3137
  
    I believe this has been fixed by #3138. If you agree, can you close this PR?


---

[GitHub] nifi pull request #3137: NIFI-5797 : EscapedJava for FlattenJson

Posted by ravib777 <gi...@git.apache.org>.

Github user ravib777 closed the pull request at:

    https://github.com/apache/nifi/pull/3137


---