[PATCH] apr-iconv: enable prelinked modules

[Mladen Turk <mt...@apache.org>]

Hi,

The patch enables building apr-iconv with the selected set of
prelinked modules. If the requested module is not found as prelinked,
then the existing mechanism (apr_dso_*) is used.

Right now the selected module list is static, so the next step would
be to make that customizable.
The prelinked modules are:

_tbl_simple, cp437, cp850, cp851, cp852,
iso-8859-1, iso-8859-2, iso-8859-5,
windows-1250, windows-1251, windows-1252

which might, or might not be the ones that are relevant, cause
for EBCDIC machines the ebcdic-* modules should be prelinked.


MT.

Re: [PATCH] apr-iconv: enable prelinked modules

[Branko Čibej <br...@xbc.nu>]

Mladen Turk wrote:

>  
>
>>-----Original Message-----
>>From: Branko Cibej [mailto:brane@xbc.nu] 
>>Sent: 11. ožujak 2003 1:40
>>To: mturk@mappingsoft.com
>>Cc: dev@apr.apache.org
>>Subject: Re: [PATCH] apr-iconv: enable prelinked modules
>>
>>    
>>
>>Mladen, most of this patch are whitespace-only changes. That 
>>makes it very hard to see the real text changes. Can you 
>>please fix that and repost? I can't review this if I have to 
>>keep track of which parts of the patch are important and 
>>which parts are just noise.
>>
>>Thanks.
>>    
>>
>
>Could you first remove the tabs from apr-iconv.
>
Huh? What do tabs in the original code have to do with your
whitespace-only changes? If your patch doesn't chang it, it shouldn't
change by itself.

>Some said 'there should be only spaces' ;).
>
Yes, that's true. We imported the apr-iconv code from elsewhere, and
didn't change either tabs or indentation. But we don't *want* to do
that, IMHO, because if we do, diffs against old versions would be useless.

So please, just insert the pertinent parts of your patch into a fresh
copy of apr-iconv, taking care to leave other whitespace alone. If I can
do that, so can you.

>I'll repost then.
>
>MT.
>
>  
>


-- 
Brane Čibej   <br...@xbc.nu>   http://www.xbc.nu/brane/

RE: [PATCH] apr-iconv: enable prelinked modules

[Mladen Turk <mt...@apache.org>]

> -----Original Message-----
> From: Branko Cibej [mailto:brane@xbc.nu] 
> Sent: 11. ožujak 2003 1:40
> To: mturk@mappingsoft.com
> Cc: dev@apr.apache.org
> Subject: Re: [PATCH] apr-iconv: enable prelinked modules
> 
> >
> Mladen, most of this patch are whitespace-only changes. That 
> makes it very hard to see the real text changes. Can you 
> please fix that and repost? I can't review this if I have to 
> keep track of which parts of the patch are important and 
> which parts are just noise.
> 
> Thanks.

Could you first remove the tabs from apr-iconv.
Some said 'there should be only spaces' ;).
I'll repost then.

MT.

Re: [PATCH] apr-iconv: enable prelinked modules

[Branko Čibej <br...@xbc.nu>]

Mladen Turk wrote:

>Hi,
>
>The patch enables building apr-iconv with the selected set of
>prelinked modules. If the requested module is not found as prelinked,
>then the existing mechanism (apr_dso_*) is used.
>
>Right now the selected module list is static, so the next step would
>be to make that customizable.
>The prelinked modules are:
>
>_tbl_simple, cp437, cp850, cp851, cp852,
>iso-8859-1, iso-8859-2, iso-8859-5,
>windows-1250, windows-1251, windows-1252
>
>which might, or might not be the ones that are relevant, cause
>for EBCDIC machines the ebcdic-* modules should be prelinked.
>
>  
>
Mladen, most of this patch are whitespace-only changes. That makes it
very hard to see the real text changes. Can you please fix that and
repost? I can't review this if I have to keep track of which parts of
the patch are important and which parts are just noise.

Thanks.

-- 
Brane Čibej   <br...@xbc.nu>   http://www.xbc.nu/brane/