You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Rajat Khandelwal <ra...@gmail.com> on 2015/03/11 07:13:46 UTC
Review Request 31926: LENS-281: Timeline should have same contract in
toProperties() and initFromProperties()
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31926/
-----------------------------------------------------------
Review request for lens.
Bugs: LENS-281
https://issues.apache.org/jira/browse/LENS-281
Repository: lens
Description
-------
1. added logs so that debugging can be easier
2. toProperties() and initFromProperties contracts should be compatible. Added test cases for the same.
Diffs
-----
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java 2e03df1aef9d07c16ba254dfc6e136f1679bf774
lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/EndsAndHolesPartitionTimeline.java 57dae9eacfbc3811d15495f9d1c7f3dba646a7fe
lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/PartitionTimeline.java 64771d00a1385ad97b65034413be232e401782c2
lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/StoreAllPartitionTimeline.java 8a9450cd25494b926a1f3e410d7254f9ce450417
lens-cube/src/test/java/org/apache/lens/cube/metadata/timeline/TestPartitionTimelines.java PRE-CREATION
Diff: https://reviews.apache.org/r/31926/diff/
Testing
-------
Waiting for test results
Thanks,
Rajat Khandelwal
Re: Review Request 31926: LENS-281: Timeline should have same
contract in toProperties() and initFromProperties()
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31926/#review76046
-----------------------------------------------------------
Ship it!
Ship It!
- Amareshwari Sriramadasu
On March 11, 2015, 6:29 a.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31926/
> -----------------------------------------------------------
>
> (Updated March 11, 2015, 6:29 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-281
> https://issues.apache.org/jira/browse/LENS-281
>
>
> Repository: lens
>
>
> Description
> -------
>
> 1. added logs so that debugging can be easier
> 2. toProperties() and initFromProperties contracts should be compatible. Added test cases for the same.
>
>
> Diffs
> -----
>
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java 2e03df1aef9d07c16ba254dfc6e136f1679bf774
> lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/EndsAndHolesPartitionTimeline.java 57dae9eacfbc3811d15495f9d1c7f3dba646a7fe
> lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/PartitionTimeline.java 64771d00a1385ad97b65034413be232e401782c2
> lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/StoreAllPartitionTimeline.java 8a9450cd25494b926a1f3e410d7254f9ce450417
> lens-cube/src/test/java/org/apache/lens/cube/metadata/timeline/TestPartitionTimelines.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/31926/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.091s]
> [INFO] Lens .............................................. SUCCESS [1.807s]
> [INFO] Lens API .......................................... SUCCESS [5.505s]
> [INFO] Lens API for server and extensions ................ SUCCESS [7.237s]
> [INFO] Lens Cube ......................................... SUCCESS [2:22.152s]
> [INFO] Lens DB storage ................................... SUCCESS [9.344s]
> [INFO] Lens Query Library ................................ SUCCESS [5.162s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:35.386s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [27.372s]
> [INFO] Lens Server ....................................... SUCCESS [4:26.708s]
> [INFO] Lens client ....................................... SUCCESS [20.536s]
> [INFO] Lens CLI .......................................... SUCCESS [1:50.268s]
> [INFO] Lens Examples ..................................... SUCCESS [0.858s]
> [INFO] Lens Distribution ................................. SUCCESS [9.768s]
> [INFO] Lens ML Lib ....................................... SUCCESS [43.822s]
> [INFO] Lens Regression ................................... SUCCESS [0.445s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 13:29.432s
> [INFO] Finished at: Wed Mar 11 06:24:56 UTC 2015
> [INFO] Final Memory: 109M/1232M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 31926: LENS-281: Timeline should have same
contract in toProperties() and initFromProperties()
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31926/
-----------------------------------------------------------
(Updated March 11, 2015, 11:59 a.m.)
Review request for lens.
Bugs: LENS-281
https://issues.apache.org/jira/browse/LENS-281
Repository: lens
Description
-------
1. added logs so that debugging can be easier
2. toProperties() and initFromProperties contracts should be compatible. Added test cases for the same.
Diffs
-----
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java 2e03df1aef9d07c16ba254dfc6e136f1679bf774
lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/EndsAndHolesPartitionTimeline.java 57dae9eacfbc3811d15495f9d1c7f3dba646a7fe
lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/PartitionTimeline.java 64771d00a1385ad97b65034413be232e401782c2
lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/StoreAllPartitionTimeline.java 8a9450cd25494b926a1f3e410d7254f9ce450417
lens-cube/src/test/java/org/apache/lens/cube/metadata/timeline/TestPartitionTimelines.java PRE-CREATION
Diff: https://reviews.apache.org/r/31926/diff/
Testing (updated)
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [2.091s]
[INFO] Lens .............................................. SUCCESS [1.807s]
[INFO] Lens API .......................................... SUCCESS [5.505s]
[INFO] Lens API for server and extensions ................ SUCCESS [7.237s]
[INFO] Lens Cube ......................................... SUCCESS [2:22.152s]
[INFO] Lens DB storage ................................... SUCCESS [9.344s]
[INFO] Lens Query Library ................................ SUCCESS [5.162s]
[INFO] Lens Hive Driver .................................. SUCCESS [2:35.386s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [27.372s]
[INFO] Lens Server ....................................... SUCCESS [4:26.708s]
[INFO] Lens client ....................................... SUCCESS [20.536s]
[INFO] Lens CLI .......................................... SUCCESS [1:50.268s]
[INFO] Lens Examples ..................................... SUCCESS [0.858s]
[INFO] Lens Distribution ................................. SUCCESS [9.768s]
[INFO] Lens ML Lib ....................................... SUCCESS [43.822s]
[INFO] Lens Regression ................................... SUCCESS [0.445s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 13:29.432s
[INFO] Finished at: Wed Mar 11 06:24:56 UTC 2015
[INFO] Final Memory: 109M/1232M
[INFO] ------------------------------------------------------------------------
Thanks,
Rajat Khandelwal