You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by panelladavide <gi...@git.apache.org> on 2017/12/12 08:49:56 UTC
[GitHub] nifi pull request #2336: NIFI-4688 - PutParquet should have RemoteOwner and ...
GitHub user panelladavide opened a pull request:
https://github.com/apache/nifi/pull/2336
NIFI-4688 - PutParquet should have RemoteOwner and RemoteGroup LE(Language Expression) turn to TRUE
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/panelladavide/nifi master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2336.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2336
----
commit 38e8de070ef4ae263983e6556e3f8775aa8c6746
Author: Davide <da...@hotmail.it>
Date: 2017-07-13T14:03:54Z
I needed to put some attributes on REMOTE_GROUP and REMOTE_OWNER, in order to achieve it i put expressionLanguageSupported(true) on the PropertyDescriptor of REMOTE_GROUP and REMOTE_OWNER
Signed-off-by: Davide <da...@hotmail.it>
commit 87eef242414e7cff4fb9c9ba1d3c18ea11d6bc09
Author: Davide <da...@hotmail.it>
Date: 2017-07-20T10:04:25Z
I needed to put some attributes on REMOTE_GROUP and REMOTE_OWNER, in order to achieve it i put expressionLanguageSupported(true) on the PropertyDescriptor of REMOTE_GROUP and REMOTE_OWNER
Signed-off-by: Davide <da...@hotmail.it>
commit dd2219b6e2f42c002461602d0e7867ca3a66bdf4
Author: Davide <da...@hotmail.it>
Date: 2017-07-21T07:08:46Z
I needed to put some attributes on REMOTE_GROUP and REMOTE_OWNER, in order to achieve it i put expressionLanguageSupported(true) on the PropertyDescriptor of REMOTE_GROUP and REMOTE_OWNER
Signed-off-by: Davide <da...@hotmail.it>
commit b63fb28a0c5fa4278d8b029c78fc429ae0b92779
Author: Davide <da...@hotmail.it>
Date: 2017-12-11T15:01:55Z
Merge remote-tracking branch 'upstream/master'
new nifi release 1.4.0
commit 51f73071f0b31f674381865211d7a6ba19b5c408
Author: Davide <da...@hotmail.it>
Date: 2017-12-11T15:32:54Z
NIFI-4688 - PutParquet should have RemoteOwner and RemoteGroup LE(Language Expression) turn to TRUE
----
---
[GitHub] nifi issue #2336: NIFI-4688 - PutParquet should have RemoteOwner and RemoteG...
Posted by pvillard31 <gi...@git.apache.org>.
Github user pvillard31 commented on the issue:
https://github.com/apache/nifi/pull/2336
Hey @panelladavide - I think the last version of your PR is missing some parts of your code. Can you take a look? Could you rebase it against master and squash commits into a single one?
---
[GitHub] nifi pull request #2336: NIFI-4688 - PutParquet should have RemoteOwner and ...
Posted by panelladavide <gi...@git.apache.org>.
Github user panelladavide commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2336#discussion_r156658395
--- Diff: nifi-nar-bundles/nifi-extension-utils/nifi-record-utils/nifi-hadoop-record-utils/src/main/java/org/apache/nifi/processors/hadoop/AbstractPutHDFSRecord.java ---
@@ -444,11 +446,17 @@ protected void deleteQuietly(final FileSystem fileSystem, final Path file) {
* @param remoteOwner the new owner for the file
* @param remoteGroup the new group for the file
*/
- protected void changeOwner(final FileSystem fileSystem, final Path path, final String remoteOwner, final String remoteGroup) {
+ protected void changeOwner(final ProcessContext context, final FileSystem fileSystem, final Path path, final String remoteOwner, final String remoteGroup,final FlowFile flowFile) {
--- End diff --
Ok, thanks.
---
[GitHub] nifi pull request #2336: NIFI-4688 - PutParquet should have RemoteOwner and ...
Posted by bbende <gi...@git.apache.org>.
Github user bbende commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2336#discussion_r156508688
--- Diff: nifi-nar-bundles/nifi-extension-utils/nifi-record-utils/nifi-hadoop-record-utils/src/main/java/org/apache/nifi/processors/hadoop/AbstractPutHDFSRecord.java ---
@@ -444,11 +446,17 @@ protected void deleteQuietly(final FileSystem fileSystem, final Path file) {
* @param remoteOwner the new owner for the file
* @param remoteGroup the new group for the file
*/
- protected void changeOwner(final FileSystem fileSystem, final Path path, final String remoteOwner, final String remoteGroup) {
+ protected void changeOwner(final ProcessContext context, final FileSystem fileSystem, final Path path, final String remoteOwner, final String remoteGroup,final FlowFile flowFile) {
--- End diff --
Since changeOwner and createDirectory already had parameters for remoteOwner and remoteGroup, can we just calculate those values in the beginning of onTrigger somewhere and pass them in? You wouldn't have to pass down the context and flow file then.
We should also get rid of the member variables for remoteOwner and remoteGroup and the code in @OnSchedule that populates them since those won't be used anymore.
---