You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by richardartoul <gi...@git.apache.org> on 2016/07/22 21:27:14 UTC
[GitHub] thrift pull request #1053: Document ability to add custom tags to thrift str...
GitHub user richardartoul opened a pull request:
https://github.com/apache/thrift/pull/1053
Document ability to add custom tags to thrift structs
This is a really useful feature that I only found out about because I stumbled upon this stackoverflow question: http://stackoverflow.com/questions/31319534/control-golang-annotations-in-thrift-generated-code
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/richardartoul/thrift patch-1
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/1053.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1053
----
commit 12a0edee0ea0d9f31c810cd0a553d1181be097ce
Author: Richard Artoul <ri...@gmail.com>
Date: 2016-07-22T21:26:53Z
Document ability to add custom tags to thrift structs
This is a really useful feature that I only found out about because I stumbled upon this stackoverflow question: http://stackoverflow.com/questions/31319534/control-golang-annotations-in-thrift-generated-code
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift issue #1053: Document ability to add custom tags to thrift structs
Posted by Jens-G <gi...@git.apache.org>.
Github user Jens-G commented on the issue:
https://github.com/apache/thrift/pull/1053
THRIFT-3998
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift issue #1053: Document ability to add custom tags to thrift structs
Posted by jpemberthy <gi...@git.apache.org>.
Github user jpemberthy commented on the issue:
https://github.com/apache/thrift/pull/1053
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift issue #1053: Document ability to add custom tags to thrift structs
Posted by Jens-G <gi...@git.apache.org>.
Github user Jens-G commented on the issue:
https://github.com/apache/thrift/pull/1053
@ulidtko: If you have a pull request ready, just post it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift issue #1053: Document ability to add custom tags to thrift structs
Posted by maximelamure <gi...@git.apache.org>.
Github user maximelamure commented on the issue:
https://github.com/apache/thrift/pull/1053
Just for information, adding custom tags generate an exception with `thriftpy` :
```
thriftpy.parser.exc.ThriftGrammerError: Grammer error '('
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift issue #1053: Document ability to add custom tags to thrift structs
Posted by richardartoul <gi...@git.apache.org>.
Github user richardartoul commented on the issue:
https://github.com/apache/thrift/pull/1053
I only submitted a change to the README, is there a way to restart the build?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift issue #1053: Document ability to add custom tags to thrift structs
Posted by ulidtko <gi...@git.apache.org>.
Github user ulidtko commented on the issue:
https://github.com/apache/thrift/pull/1053
Please also cover the field tag syntax in the IDL grammar spec [doc/specs/idl.md](/apache/thrift/tree/master/doc/specs/idl.md).
Our custom parser built per the grammar chokes on these tags as well.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request #1053: Document ability to add custom tags to thrift str...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/thrift/pull/1053
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---