[GitHub] [incubator-iceberg] mehtaashish23 commented on issue #695: [WIP] Cherrypick snapshot feature

[GitBox <gi...@apache.org>]

mehtaashish23 commented on issue #695: [WIP] Cherrypick snapshot feature
URL: https://github.com/apache/incubator-iceberg/pull/695#issuecomment-576524930
 
 
   Guys, I was checking how this cherrypick feature is going to work, and saw a discrepancy of the current work with `ExpireSnapshots` feature. Considering that we generate a new snapshot, by cherrypicking changes of a stagedSnapshot, then this stagedSnapshot is kind of dangling i.e. not on the linked chain/list of snapshots of table, which means when this gets expires then the current implementation [0] will delete the underlying manifest and dataFiles, which can be catastrophic, since the current table actually hold reference to those dataFiles.
   
   Does that make sense? If yes, then we can collaborate to come up with a fix, which shouldn't be a big effort. 
   
   [0]: https://github.com/apache/incubator-iceberg/blob/master/core/src/main/java/org/apache/iceberg/RemoveSnapshots.java#L234 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org