You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by vi...@apache.org on 2021/08/27 11:04:46 UTC

[superset] branch master updated: fix(native-filters): add handle undefined control value gracefully (#16468)

This is an automated email from the ASF dual-hosted git repository.

villebro pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/superset.git


The following commit(s) were added to refs/heads/master by this push:
     new 147637a  fix(native-filters): add handle undefined control value gracefully (#16468)
147637a is described below

commit 147637a02d259888008e03167ae69bd978f56a17
Author: Ville Brofeldt <33...@users.noreply.github.com>
AuthorDate: Fri Aug 27 14:03:05 2021 +0300

    fix(native-filters): add handle undefined control value gracefully (#16468)
---
 .../src/dashboard/components/nativeFilters/FilterBar/utils.ts           | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/superset-frontend/src/dashboard/components/nativeFilters/FilterBar/utils.ts b/superset-frontend/src/dashboard/components/nativeFilters/FilterBar/utils.ts
index 84bd6cb..af358a0 100644
--- a/superset-frontend/src/dashboard/components/nativeFilters/FilterBar/utils.ts
+++ b/superset-frontend/src/dashboard/components/nativeFilters/FilterBar/utils.ts
@@ -56,7 +56,7 @@ export const checkIsMissingRequiredValue = (
   const value = filterState?.value;
   // TODO: this property should be unhardcoded
   return (
-    filter.controlValues.enableEmptyFilter &&
+    filter.controlValues?.enableEmptyFilter &&
     (value === null || value === undefined)
   );
 };