You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by "pepness (via GitHub)" <gi...@apache.org> on 2025/02/10 21:28:58 UTC
[PR] Fix #8087-Unable to add new web service client [netbeans]
pepness opened a new pull request, #8228:
URL: https://github.com/apache/netbeans/pull/8228
[Fix issue 8087](https://github.com/apache/netbeans/issues/8087)
NetBeans Notes:
- Add support for Jakarta EE 9/10 plugins for metro, jax-ws, and maven-war-plugin
- Add support for jakarta namespaces for Jakarta EE 9 and later
- Change jax-ws group id to `com.sun.xml.ws`
- Add instance variables to `JaxWsClientCreator` that will help with the new logic to support jakarta namespaces and reduce method calls
- Use constants when possible
- Use diamond inference
- Use try-with-resources
- Increase array size
NetBeans Testing:
- Verify successful execution of libraries and licenses Ant test
- Verify successful execution of Verify Sigtests
- Verify successful execution of unit tests for modules `maven.jaxws`
- Started NetBeans and ensure the log didn't have any ERROR or new WARNINGS
- Successfully register GlassFish 5/6/7
- Create a Jakarta EE 8/9/10 maven web app and create a new `Web Service from WSDL`
- Verify that it creates a new Web Service
- Verify that the generated sources are using the correct version plugins
- Verify that the generated sources are using the correct namespace
Jakarta EE 8
Jakarta EE 9
Jakarta EE 10
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Fix #8087-Unable to add new web service client [netbeans]
Posted by "pepness (via GitHub)" <gi...@apache.org>.
pepness merged PR #8228:
URL: https://github.com/apache/netbeans/pull/8228
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Fix #8087-Unable to add new web service client [netbeans]
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on code in PR #8228:
URL: https://github.com/apache/netbeans/pull/8228#discussion_r2157967270
##########
enterprise/maven.j2ee/src/org/netbeans/modules/maven/j2ee/ear/EarImpl.java:
##########
@@ -257,15 +270,22 @@ public J2eeModule.Type getModuleType() {
*/
@Override
public String getModuleVersion() {
- Profile prf = getJ2eeProfile();
- if (prf == Profile.JAKARTA_EE_11_FULL || prf == Profile.JAKARTA_EE_11_FULL) return Application.VERSION_11;
- if (prf == Profile.JAKARTA_EE_10_FULL || prf == Profile.JAKARTA_EE_10_FULL) return Application.VERSION_10;
- if (prf == Profile.JAKARTA_EE_9_1_FULL || prf == Profile.JAKARTA_EE_9_FULL) return Application.VERSION_9;
- if (prf == Profile.JAKARTA_EE_8_FULL || prf == Profile.JAVA_EE_8_FULL) return Application.VERSION_8;
- if (prf == Profile.JAVA_EE_7_FULL) return Application.VERSION_7;
- if (prf == Profile.JAVA_EE_6_FULL) return Application.VERSION_6;
- if (prf == Profile.JAVA_EE_5) return Application.VERSION_5;
- return Application.VERSION_1_4;
+ Profile profile = getJ2eeProfile();
+ if (null == profile) {
+ return Application.VERSION_8;
+ }
+ else {
Review Comment:
nitpick: `} else {`
##########
enterprise/maven.j2ee/src/org/netbeans/modules/maven/j2ee/ear/EarImpl.java:
##########
@@ -724,10 +743,10 @@ private EarImpl.MavenModule[] readPomModules() {
}
private MavenModule[] checkConfiguration(MavenProject prj, Object conf) {
- List<MavenModule> toRet = new ArrayList<MavenModule>();
- if (conf instanceof Xpp3Dom) {
+ List<MavenModule> toRet = new ArrayList<>();
+ if (conf instanceof Xpp3Dom xpp3Dom) {
ExpressionEvaluator eval = PluginPropertyUtils.createEvaluator(project);
- Xpp3Dom dom = (Xpp3Dom) conf;
+ Xpp3Dom dom = xpp3Dom;
Xpp3Dom modules = dom.getChild("modules"); //NOI18N
Review Comment:
suggestion: replace `xpp3Dom` with `dom`,
this would allow to remove the redundant `Xpp3Dom dom = xpp3Dom;` variable.
##########
enterprise/maven.j2ee/src/org/netbeans/modules/maven/j2ee/ear/EarImpl.java:
##########
@@ -905,12 +919,26 @@ public void removePropertyChangeListener(PropertyChangeListener listener) {
@Override
public boolean equals(Object obj) {
- return module.equals(obj);
+ if (this == obj) {
+ return true;
+ }
+ if (obj == null) {
+ return false;
+ }
+ if (getClass() != obj.getClass()) {
+ return false;
+ }
+ final ProxyJ2eeModule other = (ProxyJ2eeModule) obj;
+ return Objects.equals(this.module, other.module);
}
@Override
public int hashCode() {
- return module.hashCode();
+ int hash = 5;
+ hash = 31 * hash + Objects.hashCode(this.module);
+ hash = 31 * hash + Objects.hashCode(this.mavenModule);
+ hash = 31 * hash + Objects.hashCode(this.fileNameMapping);
+ return hash;
}
Review Comment:
`equals` and `hashCode` should cover the same fields, otherwise the ["equal objects must have equal hash code"](https://docs.oracle.com/en/java/javase/24/docs/api/java.base/java/lang/Object.html#equals(java.lang.Object)) rule is broken.
##########
enterprise/maven.jaxws/src/org/netbeans/modules/maven/jaxws/WSUtils.java:
##########
@@ -137,24 +141,10 @@ public static void generateSunJaxwsFile(final FileObject targetDir) throws IOExc
@Override
public void run() throws IOException {
FileObject sunJaxwsFo = FileUtil.createData(targetDir, "sun-jaxws.xml");//NOI18N
- FileLock lock = sunJaxwsFo.lock();
- BufferedWriter bw = null;
- OutputStream os = null;
- OutputStreamWriter osw = null;
- try {
- os = sunJaxwsFo.getOutputStream(lock);
- osw = new OutputStreamWriter(os, StandardCharsets.UTF_8);
- bw = new BufferedWriter(osw);
+ try (FileLock lock = sunJaxwsFo.lock(); OutputStream os = sunJaxwsFo.getOutputStream(lock);
+ OutputStreamWriter osw = new OutputStreamWriter(os, StandardCharsets.UTF_8);
+ BufferedWriter bw = new BufferedWriter(osw)) {
bw.write(sunJaxwsContent);
- } finally {
Review Comment:
suggestion:
```java
try (FileLock lock = sunJaxwsFo.lock();
BufferedWriter bw = new BufferedWriter(
new OutputStreamWriter(sunJaxwsFo.getOutputStream(lock), StandardCharsets.UTF_8))) {
```
`bw` will close all wrapped streams.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Fix #8087-Unable to add new web service client [netbeans]
Posted by "matthiasblaesing (via GitHub)" <gi...@apache.org>.
matthiasblaesing commented on code in PR #8228:
URL: https://github.com/apache/netbeans/pull/8228#discussion_r1957383730
##########
enterprise/maven.jaxws/src/org/netbeans/modules/maven/jaxws/MavenModelUtils.java:
##########
@@ -59,14 +58,28 @@
*/
public final class MavenModelUtils {
+ private static Profile profile;
private static final String WSIPMORT_GENERATE_PREFIX = "wsimport-generate-"; //NOI18N
private static final String STALE_FILE_DIRECTORY = "${project.build.directory}/jaxws/stale/"; //NOI18N
private static final String STALE_FILE_EXTENSION = ".stale"; //NOI18N
- public static final String JAXWS_GROUP_ID = "org.jvnet.jax-ws-commons"; //NOI18N
+ public static final String JAXWS_GROUP_ID = "com.sun.xml.ws"; //NOI18N
public static final String JAXWS_ARTIFACT_ID = "jaxws-maven-plugin"; //NOI18N
public static final String JAXWS_PLUGIN_KEY = JAXWS_GROUP_ID+":"+JAXWS_ARTIFACT_ID; //NOI18N
private static final String JAXWS_CATALOG = "jax-ws-catalog.xml"; //NOI18N
- public static final String JAX_WS_PLUGIN_VERSION = "2.3"; //NOI18N
+ public static final String JAXWS_JAKARTAEE_8_PLUGIN_VERSION = "2.3.7"; //NOI18N
+ public static final String JAXWS_JAKARTAEE_9_PLUGIN_VERSION = "3.0.2"; //NOI18N
+ public static final String JAXWS_JAKARTAEE_10_PLUGIN_VERSION = "4.0.3"; //NOI18N
+
+ public static final String WEBSERVICES_METRO_GROUP_ID = "org.glassfish.metro"; //NOI18N
+ public static final String WEBSERVICES_API_ARTIFACT_ID = "webservices-api"; //NOI18N
+ public static final String WEBSERVICES_RT_ARTIFACT_ID = "webservices-rt"; //NOI18N
+ public static final String WEBSERVICES_API_JAKARTAEE_8_VERSION = "2.4.10"; //NOI18N
+ public static final String WEBSERVICES_API_JAKARTAEE_9_VERISON = "3.0.3"; //NOI18N
+ public static final String WEBSERVICES_API_JAKARTAEE_10_VERISON = "4.0.4"; //NOI18N
+
+ public static final String MAVEN_PLUGINS_GROUP_ID = "org.apache.maven.plugins"; //NOI18N
+ public static final String WAR_PLUGIN_ARTIFACT_ID = "maven-war-plugin"; //NOI18N
+ public static final String WAR_PLUGIN_VERSION = "2.3.4"; //NOI18N
Review Comment:
I would bump to `3.4.0` if there is not a very good reason to stay on the old version. I remember that I bumped several projects to a 3.X version as 2.X failed when used with JDK 21+
##########
enterprise/maven.jaxws/src/org/netbeans/modules/maven/jaxws/MavenModelUtils.java:
##########
@@ -59,14 +58,28 @@
*/
public final class MavenModelUtils {
+ private static Profile profile;
Review Comment:
This will become a problem. If you have one maven project with JakartaEE and one with JavaEE open, both will use the same `profile`. You will need to pass the "isJakarta" property (or the profile) from the external entry points, to decide per call.
A passing question: is it save to assume this is only called for JavaEE/JakarataEE projects? If it is called for JavaSE projects, there will be no profile.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Fix #8087-Unable to add new web service client [netbeans]
Posted by "matthiasblaesing (via GitHub)" <gi...@apache.org>.
matthiasblaesing commented on code in PR #8228:
URL: https://github.com/apache/netbeans/pull/8228#discussion_r3236935473
##########
enterprise/maven.jaxws/src/org/netbeans/modules/maven/jaxws/MavenModelUtils.java:
##########
@@ -689,14 +688,12 @@ private static String getJaxWsVersion(Profile profile) {
}
/**
- * Get {@code Profile} to use when generating the web service client, the
- * {@code Profile} will be computed every time there is a call to
- * {@code hasJaxWsAPI}.
+ * Get {@code Profile} to use when generating the web service client.
* @param project
- * @see hasJaxWsAPI
*/
- private static void getProfile(Project project) {
+ public Profile getProfile(Project project) {
Review Comment:
Unless I'm mistaken, `getProfile` can stay static as there is no state other than what is stored in `project` that is passed in. The instances created in the `*Creator` classes can be dropped and replaced with a static call.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Fix #8087-Unable to add new web service client [netbeans]
Posted by "pepness (via GitHub)" <gi...@apache.org>.
pepness commented on code in PR #8228:
URL: https://github.com/apache/netbeans/pull/8228#discussion_r3245270755
##########
enterprise/maven.jaxws/src/org/netbeans/modules/maven/jaxws/MavenModelUtils.java:
##########
@@ -689,14 +688,12 @@ private static String getJaxWsVersion(Profile profile) {
}
/**
- * Get {@code Profile} to use when generating the web service client, the
- * {@code Profile} will be computed every time there is a call to
- * {@code hasJaxWsAPI}.
+ * Get {@code Profile} to use when generating the web service client.
* @param project
- * @see hasJaxWsAPI
*/
- private static void getProfile(Project project) {
+ public Profile getProfile(Project project) {
Review Comment:
Good call, done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Fix #8087-Unable to add new web service client [netbeans]
Posted by "matthiasblaesing (via GitHub)" <gi...@apache.org>.
matthiasblaesing commented on PR #8228:
URL: https://github.com/apache/netbeans/pull/8228#issuecomment-4467011169
Unless I'm mistaken nothing in here touches the sig files (the most probable cause for merge conflicts after a release), so my perspective this can be merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Fix #8087-Unable to add new web service client [netbeans]
Posted by "pepness (via GitHub)" <gi...@apache.org>.
pepness commented on PR #8228:
URL: https://github.com/apache/netbeans/pull/8228#issuecomment-4456117900
All done.
> Looks sane to me.
>
> Final wish: Please check if the number of commits could be reduced. Should there be a need to revert this after merge 24 commits are really ugly to remove.
>
> Apart from that I think merging this now, i.e. early in the 31 cycle is a very good idea.
>
> Thank you!
Rebase and squash it to 10 commits.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Fix #8087-Unable to add new web service client [netbeans]
Posted by "matthiasblaesing (via GitHub)" <gi...@apache.org>.
matthiasblaesing commented on PR #8228:
URL: https://github.com/apache/netbeans/pull/8228#issuecomment-4511171556
Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Fix #8087-Unable to add new web service client [netbeans]
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #8228:
URL: https://github.com/apache/netbeans/pull/8228#issuecomment-4504560609
fyi: commit msg is now missing the first line (it is starting with a bullet point), this might not be intended
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Fix #8087-Unable to add new web service client [netbeans]
Posted by "matthiasblaesing (via GitHub)" <gi...@apache.org>.
matthiasblaesing commented on PR #8228:
URL: https://github.com/apache/netbeans/pull/8228#issuecomment-4586435948
@pepness would you mind merging this unless you think it is not ready yet?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Fix #8087-Unable to add new web service client [netbeans]
Posted by "matthiasblaesing (via GitHub)" <gi...@apache.org>.
matthiasblaesing commented on PR #8228:
URL: https://github.com/apache/netbeans/pull/8228#issuecomment-4490102959
> > Unless I'm mistaken nothing in here touches the sig files (the most probable cause for merge conflicts after a release), so my perspective this can be merged.
>
> Should I squash everything to 1 commit?
Good question. I depends on whether the commit individually make sense or should be separated. For example if code cleanup and feature work are both present in a PR I prefer separate commits, so that later it is clear what was the intention. On the other hand a single commit is easier to remove should it become necessary.
I thing there are sensible options for squashing. [57b9a65](https://github.com/apache/netbeans/pull/8228/commits/57b9a65a6a42b8e5abe6527fe37e2e7807c4c48f) looks like a candidate to keep separate, but could also be part of a single big change commit.
Does this help you?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Fix #8087-Unable to add new web service client [netbeans]
Posted by "pepness (via GitHub)" <gi...@apache.org>.
pepness commented on PR #8228:
URL: https://github.com/apache/netbeans/pull/8228#issuecomment-4473780103
> Unless I'm mistaken nothing in here touches the sig files (the most probable cause for merge conflicts after a release), so my perspective this can be merged.
Should I squash everything to 1 commit?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Fix #8087-Unable to add new web service client [netbeans]
Posted by "pepness (via GitHub)" <gi...@apache.org>.
pepness commented on code in PR #8228:
URL: https://github.com/apache/netbeans/pull/8228#discussion_r3223079049
##########
enterprise/maven.jaxws/src/org/netbeans/modules/maven/jaxws/MavenModelUtils.java:
##########
@@ -59,14 +58,28 @@
*/
public final class MavenModelUtils {
+ private static Profile profile;
private static final String WSIPMORT_GENERATE_PREFIX = "wsimport-generate-"; //NOI18N
private static final String STALE_FILE_DIRECTORY = "${project.build.directory}/jaxws/stale/"; //NOI18N
private static final String STALE_FILE_EXTENSION = ".stale"; //NOI18N
- public static final String JAXWS_GROUP_ID = "org.jvnet.jax-ws-commons"; //NOI18N
+ public static final String JAXWS_GROUP_ID = "com.sun.xml.ws"; //NOI18N
public static final String JAXWS_ARTIFACT_ID = "jaxws-maven-plugin"; //NOI18N
public static final String JAXWS_PLUGIN_KEY = JAXWS_GROUP_ID+":"+JAXWS_ARTIFACT_ID; //NOI18N
private static final String JAXWS_CATALOG = "jax-ws-catalog.xml"; //NOI18N
- public static final String JAX_WS_PLUGIN_VERSION = "2.3"; //NOI18N
+ public static final String JAXWS_JAKARTAEE_8_PLUGIN_VERSION = "2.3.7"; //NOI18N
+ public static final String JAXWS_JAKARTAEE_9_PLUGIN_VERSION = "3.0.2"; //NOI18N
+ public static final String JAXWS_JAKARTAEE_10_PLUGIN_VERSION = "4.0.3"; //NOI18N
+
+ public static final String WEBSERVICES_METRO_GROUP_ID = "org.glassfish.metro"; //NOI18N
+ public static final String WEBSERVICES_API_ARTIFACT_ID = "webservices-api"; //NOI18N
+ public static final String WEBSERVICES_RT_ARTIFACT_ID = "webservices-rt"; //NOI18N
+ public static final String WEBSERVICES_API_JAKARTAEE_8_VERSION = "2.4.10"; //NOI18N
+ public static final String WEBSERVICES_API_JAKARTAEE_9_VERISON = "3.0.3"; //NOI18N
+ public static final String WEBSERVICES_API_JAKARTAEE_10_VERISON = "4.0.4"; //NOI18N
+
+ public static final String MAVEN_PLUGINS_GROUP_ID = "org.apache.maven.plugins"; //NOI18N
+ public static final String WAR_PLUGIN_ARTIFACT_ID = "maven-war-plugin"; //NOI18N
+ public static final String WAR_PLUGIN_VERSION = "2.3.4"; //NOI18N
Review Comment:
Bump to latest version 3.5.1
##########
enterprise/maven.jaxws/src/org/netbeans/modules/maven/jaxws/MavenModelUtils.java:
##########
@@ -59,14 +58,28 @@
*/
public final class MavenModelUtils {
+ private static Profile profile;
Review Comment:
Java EE 8 will use model 2.2, Jakarta EE 9/10/11 will use 3.0, tested with Maven Web, EJB, and JavaSE projects with different Java and Java/Jakarta EE versions, each call will compute the correct API to use.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Fix #8087-Unable to add new web service client [netbeans]
Posted by "matthiasblaesing (via GitHub)" <gi...@apache.org>.
matthiasblaesing commented on PR #8228:
URL: https://github.com/apache/netbeans/pull/8228#issuecomment-3240339480
@pepness what is the state of this? I think it would be good to rebase this onto current master, cleanup the history and check if all comments are addressed. The static `profile` variable is still there and globals like these are really ugly to debug.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Fix #8087-Unable to add new web service client [netbeans]
Posted by "pepness (via GitHub)" <gi...@apache.org>.
pepness commented on PR #8228:
URL: https://github.com/apache/netbeans/pull/8228#issuecomment-4426952805
> @pepness what is the state of this? I think it would be good to rebase this onto current master, cleanup the history and check if all comments are addressed. The static `profile` variable is still there and globals like these are really ugly to debug.
I updated some maven plugins and removed the use of the static variable. Will re-test everything and finish by tomorrow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Fix #8087-Unable to add new web service client [netbeans]
Posted by "pepness (via GitHub)" <gi...@apache.org>.
pepness commented on PR #8228:
URL: https://github.com/apache/netbeans/pull/8228#issuecomment-4510437975
> fyi: commit msg is now missing the first line (it is starting with a bullet point), this might not be intended
>
> edit: usually its the pr title or a one sentence summary, followed by blank line
You are right, I fixed the commit message.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Fix #8087-Unable to add new web service client [netbeans]
Posted by "pepness (via GitHub)" <gi...@apache.org>.
pepness commented on PR #8228:
URL: https://github.com/apache/netbeans/pull/8228#issuecomment-4443685398
All done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists