[GitHub] tajo pull request: TAJO-1359: Add nested field projector and langu...

[jihoonson <gi...@git.apache.org>]

Github user jihoonson commented on a diff in the pull request:

    https://github.com/apache/tajo/pull/422#discussion_r29857765
  
    --- Diff: tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/NestedPathUtil.java ---
    @@ -0,0 +1,109 @@
    +/**
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.tajo.catalog;
    +
    +import com.google.common.base.Preconditions;
    +import org.apache.tajo.common.TajoDataTypes.Type;
    +
    +import java.util.ArrayList;
    +import java.util.Collections;
    +import java.util.List;
    +
    +/**
    + * Utility methods for nested field
    + */
    +public class NestedPathUtil {
    +  public static final String PATH_DELIMITER = "/";
    +
    +  public static final List<String> ROOT_PATH = Collections.unmodifiableList(new ArrayList<String>());
    +
    +  public static boolean isPath(String name) {
    +    return name.indexOf(PATH_DELIMITER.charAt(0)) >= 0;
    +  }
    +
    +  public static String make(String [] parts) {
    +    return make(parts, 0);
    +  }
    +
    +  public static String make(String [] parts, int startIndex) {
    +    return make(parts, startIndex, parts.length);
    +  }
    +
    +  /**
    +   * Make a nested field path
    +   *
    +   * @param parts path parts
    +   * @param startIndex startIndex
    +   * @param depth Depth
    +   * @return Path
    +   */
    +  public static String make(String [] parts, int startIndex, int depth) {
    --- End diff --
    
    It would be nice if the method name is more intuitive.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---