You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kylin.apache.org by li...@apache.org on 2016/04/22 06:11:50 UTC
[21/50] [abbrv] kylin git commit: minor, fix some comments
minor, fix some comments
Project: http://git-wip-us.apache.org/repos/asf/kylin/repo
Commit: http://git-wip-us.apache.org/repos/asf/kylin/commit/34c6ece4
Tree: http://git-wip-us.apache.org/repos/asf/kylin/tree/34c6ece4
Diff: http://git-wip-us.apache.org/repos/asf/kylin/diff/34c6ece4
Branch: refs/heads/1.5.x-HBase1.1.3
Commit: 34c6ece41bef0f6aecc68450d285bc75d956d226
Parents: 0e662a3
Author: Li Yang <li...@apache.org>
Authored: Fri Apr 1 17:28:10 2016 +0800
Committer: Li Yang <li...@apache.org>
Committed: Fri Apr 1 17:28:19 2016 +0800
----------------------------------------------------------------------
.../kylin/storage/hbase/cube/v2/CubeHBaseEndpointRPC.java | 1 +
.../apache/kylin/storage/hbase/cube/v2/CubeSegmentScanner.java | 6 ++----
2 files changed, 3 insertions(+), 4 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/kylin/blob/34c6ece4/storage-hbase/src/main/java/org/apache/kylin/storage/hbase/cube/v2/CubeHBaseEndpointRPC.java
----------------------------------------------------------------------
diff --git a/storage-hbase/src/main/java/org/apache/kylin/storage/hbase/cube/v2/CubeHBaseEndpointRPC.java b/storage-hbase/src/main/java/org/apache/kylin/storage/hbase/cube/v2/CubeHBaseEndpointRPC.java
index f36ab29..31977ae 100644
--- a/storage-hbase/src/main/java/org/apache/kylin/storage/hbase/cube/v2/CubeHBaseEndpointRPC.java
+++ b/storage-hbase/src/main/java/org/apache/kylin/storage/hbase/cube/v2/CubeHBaseEndpointRPC.java
@@ -237,6 +237,7 @@ public class CubeHBaseEndpointRPC extends CubeHBaseRPC {
return split;
}
+ @SuppressWarnings("unchecked")
private List<Pair<byte[], byte[]>> getEPKeyRanges(short baseShard, short shardNum, int totalShards) {
if (baseShard + shardNum <= totalShards) {
//endpoint end key is inclusive, so no need to append 0 or anything
http://git-wip-us.apache.org/repos/asf/kylin/blob/34c6ece4/storage-hbase/src/main/java/org/apache/kylin/storage/hbase/cube/v2/CubeSegmentScanner.java
----------------------------------------------------------------------
diff --git a/storage-hbase/src/main/java/org/apache/kylin/storage/hbase/cube/v2/CubeSegmentScanner.java b/storage-hbase/src/main/java/org/apache/kylin/storage/hbase/cube/v2/CubeSegmentScanner.java
index b95fce9..6bbb9c0 100644
--- a/storage-hbase/src/main/java/org/apache/kylin/storage/hbase/cube/v2/CubeSegmentScanner.java
+++ b/storage-hbase/src/main/java/org/apache/kylin/storage/hbase/cube/v2/CubeSegmentScanner.java
@@ -251,12 +251,10 @@ public class CubeSegmentScanner implements IGTScanner {
return info.getCodeSystem().getDimEnc(col.getColumnDesc().getZeroBasedIndex());
}
});
- rpc = new CubeHBaseScanRPC(cubeSeg, cuboid, info);
+ rpc = new CubeHBaseScanRPC(cubeSeg, cuboid, info); // for local debug
} else {
- rpc = new CubeHBaseEndpointRPC(cubeSeg, cuboid, info);//default behavior
+ rpc = new CubeHBaseEndpointRPC(cubeSeg, cuboid, info); // default behavior
}
- //change previous line to CubeHBaseRPC rpc = new CubeHBaseScanRPC(cubeSeg, cuboid, info);
- //to debug locally
try {
if (scanRequests.size() == 0) {