You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/05/21 16:03:42 UTC
[GitHub] [arrow] anthonylouisbsb commented on a change in pull request #10350: ARROW-12814: [C++][Gandiva] Implements the ABS, FLOOR, PI, SQRT, SIGN, LSHIFT, RSHIFT, CEIL and TRUNC functions
anthonylouisbsb commented on a change in pull request #10350:
URL: https://github.com/apache/arrow/pull/10350#discussion_r637037791
##########
File path: cpp/src/gandiva/gdv_function_stubs_test.cc
##########
@@ -290,4 +299,53 @@ TEST(TestGdvFnStubs, TestCastVARCHARFromDouble) {
EXPECT_FALSE(ctx.has_error());
}
+TEST(TestGdvFnStubs, TestAbs) {
+ gandiva::ExecutionContext ctx;
+ uint64_t ctx_ptr = reinterpret_cast<int64_t>(&ctx);
+
+ // Abs functions
+ EXPECT_EQ(gdv_fn_abs_int32(ctx_ptr, 0), 0);
+ EXPECT_EQ(gdv_fn_abs_uint32(ctx_ptr, 0), 0);
+ EXPECT_EQ(gdv_fn_abs_int64(ctx_ptr, 0), 0L);
+ EXPECT_EQ(gdv_fn_abs_uint64(ctx_ptr, 0), 0L);
+ VerifyAlmostEquals(gdv_fn_abs_float32(ctx_ptr, 0.0f), abs(0.0f));
+ VerifyAlmostEquals(gdv_fn_abs_float64(ctx_ptr, 0.0), abs(0.0));
+
+ VerifyAlmostEquals(gdv_fn_abs_int32(ctx_ptr, (INT32_MIN + 1)),
+ abs(static_cast<double>(INT32_MIN + 1)));
+ VerifyAlmostEquals(gdv_fn_abs_int64(ctx_ptr, (INT32_MIN + 1)),
+ abs(static_cast<double>(INT32_MIN + 1)));
+ VerifyAlmostEquals(gdv_fn_abs_float32(ctx_ptr, static_cast<float>(INT32_MIN + 1)),
+ abs(static_cast<float>(INT32_MIN + 1)));
+ VerifyAlmostEquals(gdv_fn_abs_float64(ctx_ptr, static_cast<double>(INT32_MIN + 1)),
+ abs(static_cast<double>(INT32_MIN + 1)));
+
+ EXPECT_EQ(gdv_fn_abs_int64(ctx_ptr, (INT64_MIN + 1)),
Review comment:
@kiszk Thanks for your revision! Please, could you explain how would occur digit loss here? I did not understand what you said.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org