You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/10/09 04:54:50 UTC
[GitHub] [cloudstack-primate] Pearl1594 opened a new pull request #796: Add storage policy details in the detail view
Pearl1594 opened a new pull request #796:
URL: https://github.com/apache/cloudstack-primate/pull/796
Adds storage policy details in the detail view tab of a Disk and Compute offering
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #796: Add storage policy details in the detail view
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #796:
URL: https://github.com/apache/cloudstack-primate/pull/796#issuecomment-705967373
@Pearl1594 a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on a change in pull request #796: Add storage policy details in the detail view
Posted by GitBox <gi...@apache.org>.
rhtyd commented on a change in pull request #796:
URL: https://github.com/apache/cloudstack-primate/pull/796#discussion_r503120718
##########
File path: src/config/section/offering.js
##########
@@ -111,7 +118,13 @@ export default {
permission: ['listDiskOfferings', 'listDomains'],
params: { isrecursive: 'true' },
columns: ['name', 'displaytext', 'disksize', 'domain', 'zone', 'order'],
- details: ['name', 'id', 'displaytext', 'disksize', 'provisioningtype', 'storagetype', 'iscustomized', 'tags', 'domain', 'zone', 'created'],
+ details: () => {
+ var fields = ['name', 'id', 'displaytext', 'disksize', 'provisioningtype', 'storagetype', 'iscustomized', 'tags', 'domain', 'zone', 'created']
+ if (store.getters.apis.createDiskOffering.params.filter(x => x.name === 'storagepolicy').length > 0) {
Review comment:
@Pearl1594 can you add check what if the API doesn't exist or is available?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd merged pull request #796: Add storage policy details in the detail view
Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #796:
URL: https://github.com/apache/cloudstack-primate/pull/796
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] Pearl1594 commented on pull request #796: Add storage policy details in the detail view
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #796:
URL: https://github.com/apache/cloudstack-primate/pull/796#issuecomment-705967127
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] Pearl1594 commented on pull request #796: Add storage policy details in the detail view
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #796:
URL: https://github.com/apache/cloudstack-primate/pull/796#issuecomment-706969116
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on a change in pull request #796: Add storage policy details in the detail view
Posted by GitBox <gi...@apache.org>.
rhtyd commented on a change in pull request #796:
URL: https://github.com/apache/cloudstack-primate/pull/796#discussion_r503120904
##########
File path: src/config/section/offering.js
##########
@@ -29,7 +30,13 @@ export default {
permission: ['listServiceOfferings', 'listDomains'],
params: { isrecursive: 'true' },
columns: ['name', 'displaytext', 'cpunumber', 'cpuspeed', 'memory', 'domain', 'zone', 'order'],
- details: ['name', 'id', 'displaytext', 'offerha', 'provisioningtype', 'storagetype', 'iscustomized', 'limitcpuuse', 'cpunumber', 'cpuspeed', 'memory', 'hosttags', 'tags', 'domain', 'zone', 'created'],
+ details: () => {
+ var fields = ['name', 'id', 'displaytext', 'offerha', 'provisioningtype', 'storagetype', 'iscustomized', 'limitcpuuse', 'cpunumber', 'cpuspeed', 'memory', 'hosttags', 'tags', 'domain', 'zone', 'created']
+ if (store.getters.apis.createServiceOffering.params.filter(x => x.name === 'storagepolicy').length > 0) {
Review comment:
We need an undefined/null check
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] Pearl1594 commented on pull request #796: Add storage policy details in the detail view
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #796:
URL: https://github.com/apache/cloudstack-primate/pull/796#issuecomment-705967127
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #796: Add storage policy details in the detail view
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #796:
URL: https://github.com/apache/cloudstack-primate/pull/796#issuecomment-705967373
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] borisstoyanov commented on pull request #796: Add storage policy details in the detail view
Posted by GitBox <gi...@apache.org>.
borisstoyanov commented on pull request #796:
URL: https://github.com/apache/cloudstack-primate/pull/796#issuecomment-706093536
LGTM
<img width="1028" alt="Screen Shot 2020-10-09 at 13 02 49" src="https://user-images.githubusercontent.com/13551960/95570987-6c807d00-0a30-11eb-832a-2879d4c06477.png">
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] borisstoyanov commented on pull request #796: Add storage policy details in the detail view
Posted by GitBox <gi...@apache.org>.
borisstoyanov commented on pull request #796:
URL: https://github.com/apache/cloudstack-primate/pull/796#issuecomment-706093536
LGTM
<img width="1028" alt="Screen Shot 2020-10-09 at 13 02 49" src="https://user-images.githubusercontent.com/13551960/95570987-6c807d00-0a30-11eb-832a-2879d4c06477.png">
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #796: Add storage policy details in the detail view
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #796:
URL: https://github.com/apache/cloudstack-primate/pull/796#issuecomment-706974289
Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/796 (JID-3579)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] Pearl1594 commented on pull request #796: Add storage policy details in the detail view
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #796:
URL: https://github.com/apache/cloudstack-primate/pull/796#issuecomment-706968685
@rhtyd added check for existence of API
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #796: Add storage policy details in the detail view
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #796:
URL: https://github.com/apache/cloudstack-primate/pull/796#issuecomment-706969473
@Pearl1594 a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #796: Add storage policy details in the detail view
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #796:
URL: https://github.com/apache/cloudstack-primate/pull/796#issuecomment-705969848
Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/796 (JID-3571)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org