[GitHub] [cloudstack] SadiJr commented on a change in pull request #5357: Externalize VMWare stats time window config

[GitBox <gi...@apache.org>]

SadiJr commented on a change in pull request #5357:
URL: https://github.com/apache/cloudstack/pull/5357#discussion_r694978196



##########
File path: plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/manager/VmwareManager.java
##########
@@ -46,6 +46,10 @@
     static final ConfigKey<Integer> s_vmwareOVAPackageTimeout = new ConfigKey<Integer>(Integer.class, "vmware.package.ova.timeout", "Advanced", "3600",
             "Vmware script timeout for ova packaging process", true, ConfigKey.Scope.Global, 1000);
 
+    public static final ConfigKey<Integer> VMWARE_STATS_TIME_WINDOW = new ConfigKey<Integer>("Advanced", Integer.class, "vmware.stats.time.window", "300",

Review comment:
       Hi @sureshanaparti, thanks for the review. About changing this to keep the format at the other configs, I really don't think this is a good action. This config is a constant, and, according to [Java naming conventions](https://www.oracle.com/java/technologies/javase/codeconventions-namingconventions.html), and [ACS naming conventions](https://cwiki.apache.org/confluence/display/CLOUDSTACK/Coding+conventions) , constants must be written in uppercase, separated by _. Keeping new settings in the old format does not sound like a good practice.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org