You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "Michael-J-Ward (via GitHub)" <gi...@apache.org> on 2024/07/30 19:09:15 UTC
[PR] fix: regr_count now returns Uint64 [datafusion]
Michael-J-Ward opened a new pull request, #11731:
URL: https://github.com/apache/datafusion/pull/11731
## Which issue does this PR close?
Closes #11726.
## Rationale for this change
Consistent with `count` expectations and postgres, `regr_count` aggregate function should return an integer, not a float.
## What changes are included in this PR?
The UDAF and it's corresponding SQL tests have been updated.
## Are these changes tested?
Yes, via updating the `aggregate.slt` tests.
## Are there any user-facing changes?
Yes - `regr_count` returns a different `DataType`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] fix: regr_count now returns Uint64 [datafusion]
Posted by "jayzhan211 (via GitHub)" <gi...@apache.org>.
jayzhan211 commented on PR #11731:
URL: https://github.com/apache/datafusion/pull/11731#issuecomment-2259387771
Thanks @Michael-J-Ward and @alamb
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] fix: regr_count now returns Uint64 [datafusion]
Posted by "jayzhan211 (via GitHub)" <gi...@apache.org>.
jayzhan211 merged PR #11731:
URL: https://github.com/apache/datafusion/pull/11731
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org