[GitHub] [incubator-uniffle] advancedxy commented on pull request #510: [ISSUE-509] Fix Flaky Test: ShuffleBufferManagerTest#shuffleFlushThreshold

["advancedxy (via GitHub)" <gi...@apache.org>]

advancedxy commented on PR #510:
URL: https://github.com/apache/incubator-uniffle/pull/510#issuecomment-1407613119

   > Thanks @xianjingfeng for updating the PR, @advancedxy what do you think?
   
   Thanks @xianjingfeng for your help. This code generally looks good to me with one minor comment. And I believe after introduce the flush method, some other tests may also be refactored to use the flush method instead of `waitForFlush`. But that should be addressed in another issue/pr.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org