You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Joshua Cohen <jc...@apache.org> on 2015/12/28 16:58:25 UTC
Review Request 41743: Added a note for committers on formatting commit
messages generated by ./rbt patch
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41743/
-----------------------------------------------------------
Review request for Aurora and Bill Farner.
Repository: aurora
Description
-------
Added a note for committers on formatting commit messages generated by ./rbt patch
Diffs
-----
CONTRIBUTING.md 59ac8295252ee47890627ec56b5d69c1f1d05776
Diff: https://reviews.apache.org/r/41743/diff/
Testing
-------
Thanks,
Joshua Cohen
Re: Review Request 41743: Added a note for committers on formatting
commit messages generated by ./rbt patch
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41743/#review112002
-----------------------------------------------------------
Ship it!
Master (f56ea26) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Dec. 28, 2015, 3:58 p.m., Joshua Cohen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41743/
> -----------------------------------------------------------
>
> (Updated Dec. 28, 2015, 3:58 p.m.)
>
>
> Review request for Aurora and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Added a note for committers on formatting commit messages generated by ./rbt patch
>
>
> Diffs
> -----
>
> CONTRIBUTING.md 59ac8295252ee47890627ec56b5d69c1f1d05776
>
> Diff: https://reviews.apache.org/r/41743/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Joshua Cohen
>
>
Re: Review Request 41743: Added a note for committers on formatting
commit messages generated by ./rbt patch
Posted by Bill Farner <wf...@apache.org>.
> On Dec. 28, 2015, 7:58 a.m., Joshua Cohen wrote:
> > CONTRIBUTING.md, line 83
> > <https://reviews.apache.org/r/41743/diff/1/?file=1176899#file1176899line83>
> >
> > Let me know if you think this should be 100 chars?
Yeah, makes sense to match other column limits we use.
- Bill
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41743/#review111994
-----------------------------------------------------------
On Dec. 28, 2015, 7:58 a.m., Joshua Cohen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41743/
> -----------------------------------------------------------
>
> (Updated Dec. 28, 2015, 7:58 a.m.)
>
>
> Review request for Aurora and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Added a note for committers on formatting commit messages generated by ./rbt patch
>
>
> Diffs
> -----
>
> CONTRIBUTING.md 59ac8295252ee47890627ec56b5d69c1f1d05776
>
> Diff: https://reviews.apache.org/r/41743/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Joshua Cohen
>
>
Re: Review Request 41743: Added a note for committers on formatting
commit messages generated by ./rbt patch
Posted by Joshua Cohen <jc...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41743/#review111994
-----------------------------------------------------------
CONTRIBUTING.md (line 83)
<https://reviews.apache.org/r/41743/#comment172308>
Let me know if you think this should be 100 chars?
- Joshua Cohen
On Dec. 28, 2015, 3:58 p.m., Joshua Cohen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41743/
> -----------------------------------------------------------
>
> (Updated Dec. 28, 2015, 3:58 p.m.)
>
>
> Review request for Aurora and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Added a note for committers on formatting commit messages generated by ./rbt patch
>
>
> Diffs
> -----
>
> CONTRIBUTING.md 59ac8295252ee47890627ec56b5d69c1f1d05776
>
> Diff: https://reviews.apache.org/r/41743/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Joshua Cohen
>
>
Re: Review Request 41743: Added a note for committers on formatting
commit messages generated by ./rbt patch
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41743/#review112007
-----------------------------------------------------------
Ship it!
Ship It!
- Bill Farner
On Dec. 28, 2015, 7:58 a.m., Joshua Cohen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41743/
> -----------------------------------------------------------
>
> (Updated Dec. 28, 2015, 7:58 a.m.)
>
>
> Review request for Aurora and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Added a note for committers on formatting commit messages generated by ./rbt patch
>
>
> Diffs
> -----
>
> CONTRIBUTING.md 59ac8295252ee47890627ec56b5d69c1f1d05776
>
> Diff: https://reviews.apache.org/r/41743/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Joshua Cohen
>
>
Re: Review Request 41743: Added a note for committers on formatting
commit messages generated by ./rbt patch
Posted by Joshua Cohen <jc...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41743/
-----------------------------------------------------------
(Updated Dec. 28, 2015, 5:15 p.m.)
Review request for Aurora and Bill Farner.
Changes
-------
Up line length limit to 100 chars.
Repository: aurora
Description
-------
Added a note for committers on formatting commit messages generated by ./rbt patch
Diffs (updated)
-----
CONTRIBUTING.md 59ac8295252ee47890627ec56b5d69c1f1d05776
Diff: https://reviews.apache.org/r/41743/diff/
Testing
-------
Thanks,
Joshua Cohen