You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by James Peach <jp...@apache.org> on 2017/11/30 22:03:35 UTC
Review Request 64226: Added a `ns::supported` convenience API.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64226/
-----------------------------------------------------------
Review request for mesos and Jie Yu.
Bugs: MESOS-8284
https://issues.apache.org/jira/browse/MESOS-8284
Repository: mesos
Description
-------
Added a `ns::supported` convenience API which directly expresses the
intent to probe whether a specific Linux namespace is supported on
the running kernel and takes care of kernel versioning special cases.
Diffs
-----
3rdparty/stout/include/stout/internal/windows/longpath.hpp 499eef30a3d16ac1f6c2e3334ef773e91e987a45
3rdparty/stout/include/stout/internal/windows/reparsepoint.hpp 158f44550327c63fb416052ad9978b55e4efe36b
3rdparty/stout/include/stout/internal/windows/symlink.hpp def5515656a5a454655d6a484c7e52ea12be8a55
3rdparty/stout/include/stout/os/windows/exists.hpp 50bb92a1e4100a89a346d6bafc6d4133e6e40589
3rdparty/stout/include/stout/os/windows/realpath.hpp c6bad5063c8d8255b29a3a6cb9ea51e13c42275c
3rdparty/stout/include/stout/os/windows/rm.hpp 1c66e3e6fa20116866842378077e10052c147289
3rdparty/stout/include/stout/os/windows/rmdir.hpp a2926dab2c8e219cf5938c4df27f83488198dd6b
3rdparty/stout/include/stout/os/windows/shell.hpp 542039c31f94eda1af121335b12edf9b83725ae5
3rdparty/stout/include/stout/os/windows/stat.hpp 2ba6969a78eb6ed7007a3d404d5179b143790480
3rdparty/stout/include/stout/windows/fs.hpp bc7cf025c9228a65f2ae0fab9ba27b386d189b46
3rdparty/stout/include/stout/windows/os.hpp 09469e9380e1eb64df34897f8becffda0a898e9d
3rdparty/stout/tests/os/rmdir_tests.cpp 2fd24a825068019423674f74fb71cc61d3c504b5
3rdparty/stout/tests/os_tests.cpp 26514f3604fcc81effbfcb6845116a62021272ca
include/mesos/allocator/allocator.hpp acb9e4f6a843e64c915c43c218d8a533ca63333b
src/checks/tcp_connect.cpp f5df732415b1e3ac02e9624909d822febe60fe8c
src/linux/ns.hpp e24d79a41eefcade343b2825b5a758d7d30a5f91
src/linux/ns.cpp 5e2df1ed56432c6c1bfa04a31dba7f9f547d6139
src/master/allocator/mesos/allocator.hpp 48254b6e0974bdc16ffda04d3d271538048d3206
src/master/allocator/mesos/hierarchical.hpp 3c87dc797cf70f3aa48b1ed9f86d673d4ea2fe76
src/master/allocator/mesos/hierarchical.cpp ab2abf868f9252154d934243521622c5cb107182
src/master/master.hpp 1425080a8907a827838a75c0bf6c9e8cb27d8437
src/master/master.cpp eadc008fbdc53a95ab80584ffcd9b76a4a67a3c2
src/slave/constants.hpp 2d07bce299e63b8492a5ecb08b29508a671bc14c
src/slave/containerizer/docker.cpp d837442ca073d6872c94a9332599423c005a8874
src/slave/containerizer/mesos/isolators/namespaces/ipc.cpp 2d89d598d24e3bcf01d652ce3f586c9e3ccfc20b
src/slave/containerizer/mesos/isolators/namespaces/pid.cpp 4f8253b58018581e022eb1832b9b07703cbd318d
src/slave/containerizer/mesos/isolators/network/port_mapping.cpp d60052e9e1ccdfaaac6c0db6acfdae325cea6a9e
src/slave/containerizer/mesos/launch.cpp b1065be0d12934e9b10feadb7d1b82af8ad7cebc
src/slave/slave.cpp a9aa987ade67542b85aeb51356d00a4c14c6be9d
src/tests/allocator.hpp fc5d9efc8dab3bd971fa8938e3f82e8291c4ab9d
src/tests/cluster.cpp b530133fa77572f00ef8a945d3466a27eb95ceab
src/tests/containerizer/ns_tests.cpp 61adf8525b1df1a70d7fd9c747d2106630a7627d
src/tests/flags.hpp df4d4588f405ea884bb89021264e70218e054fae
src/tests/hierarchical_allocator_tests.cpp 0309074bab180be122c9b0074981e6f69c97feee
src/tests/mesos.hpp c871878fb1e2ea2716da6232ea0ed766399068b6
src/tests/slave_tests.cpp 1344e0a5376137b5b933edc9ea4a83be58542654
Diff: https://reviews.apache.org/r/64226/diff/1/
Testing
-------
make check (Fedora 27)
Thanks,
James Peach
Re: Review Request 64226: Added a `ns::supported` convenience API.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64226/#review192472
-----------------------------------------------------------
FAIL: Mesos libprocess-tests failed to build
Reviews applied: `['64226']`
Failed command: `cmake.exe --build . --target libprocess-tests --config Debug`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64226
Relevant logs:
- [libprocess-tests-build-cmake-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64226/logs/libprocess-tests-build-cmake-stdout.log):
```
C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(62): warning C4996: 'GetVersionExW': was declared deprecated (compiling source file C:\DCOS\mesos\mesos\3rdparty\libprocess\src\tests\state_machine_tests.cpp) [C:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj]
C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(451): warning C4996: 'GetVersionExW': was declared deprecated (compiling source file C:\DCOS\mesos\mesos\3rdparty\libprocess\src\tests\state_machine_tests.cpp) [C:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj]
C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(805): warning C4244: 'argument': conversion from 'ULONG_PTR' to 'pid_t', possible loss of data (compiling source file C:\DCOS\mesos\mesos\3rdparty\libprocess\src\tests\state_machine_tests.cpp) [C:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj]
C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(62): warning C4996: 'GetVersionExW': was declared deprecated (compiling source file C:\DCOS\mesos\mesos\3rdparty\libprocess\src\tests\subprocess_tests.cpp) [C:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj]
C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(451): warning C4996: 'GetVersionExW': was declared deprecated (compiling source file C:\DCOS\mesos\mesos\3rdparty\libprocess\src\tests\subprocess_tests.cpp) [C:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj]
C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(62): warning C4996: 'GetVersionExW': was declared deprecated (compiling source file C:\DCOS\mesos\mesos\3rdparty\libprocess\src\tests\system_tests.cpp) [C:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj]
C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(451): warning C4996: 'GetVersionExW': was declared deprecated (compiling source file C:\DCOS\mesos\mesos\3rdparty\libprocess\src\tests\system_tests.cpp) [C:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj]
C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(805): warning C4244: 'argument': conversion from 'ULONG_PTR' to 'pid_t', possible loss of data (compiling source file C:\DCOS\mesos\mesos\3rdparty\libprocess\src\tests\subprocess_tests.cpp) [C:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj]
C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(805): warning C4244: 'argument': conversion from 'ULONG_PTR' to 'pid_t', possible loss of data (compiling source file C:\DCOS\mesos\mesos\3rdparty\libprocess\src\tests\system_tests.cpp) [C:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj]
C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(62): warning C4996: 'GetVersionExW': was declared deprecated (compiling source file C:\DCOS\mesos\mesos\3rdparty\libprocess\src\tests\time_tests.cpp) [C:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj]
C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(451): warning C4996: 'GetVersionExW': was declared deprecated (compiling source file C:\DCOS\mesos\mesos\3rdparty\libprocess\src\tests\time_tests.cpp) [C:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj]
C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(805): warning C4244: 'argument': conversion from 'ULONG_PTR' to 'pid_t', possible loss of data (compiling source file C:\DCOS\mesos\mesos\3rdparty\libprocess\src\tests\time_tests.cpp) [C:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj]
C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(62): warning C4996: 'GetVersionExW': was declared deprecated (compiling source file C:\DCOS\mesos\mesos\3rdparty\libprocess\src\tests\ssl_tests.cpp) [C:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj]
C:\DCOS\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(451): warning C4996: 'GetVersionExW': was declared deprecated (compiling source file C:\DCOS\mesos\mesos\3rdparty\libprocess\src\tests\ssl_tests.cpp) [C:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj]
"C:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj" (default target) (1) ->
(ClCompile target) ->
C:\DCOS\mesos\mesos\3rdparty\libprocess\include\process/ssl/gtest.hpp(355): error C2039: 'realpath': is not a member of 'os' (compiling source file C:\DCOS\mesos\mesos\3rdparty\libprocess\src\tests\http_tests.cpp) [C:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj]
C:\DCOS\mesos\mesos\3rdparty\libprocess\include\process/ssl/gtest.hpp(355): error C3861: 'realpath': identifier not found (compiling source file C:\DCOS\mesos\mesos\3rdparty\libprocess\src\tests\http_tests.cpp) [C:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj]
C:\DCOS\mesos\mesos\3rdparty\libprocess\include\process/ssl/gtest.hpp(355): error C2039: 'realpath': is not a member of 'os' (compiling source file C:\DCOS\mesos\mesos\3rdparty\libprocess\src\tests\socket_tests.cpp) [C:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj]
C:\DCOS\mesos\mesos\3rdparty\libprocess\include\process/ssl/gtest.hpp(355): error C3861: 'realpath': identifier not found (compiling source file C:\DCOS\mesos\mesos\3rdparty\libprocess\src\tests\socket_tests.cpp) [C:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj]
C:\DCOS\mesos\mesos\3rdparty\libprocess\include\process/ssl/gtest.hpp(355): error C2039: 'realpath': is not a member of 'os' (compiling source file C:\DCOS\mesos\mesos\3rdparty\libprocess\src\tests\ssl_tests.cpp) [C:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj]
C:\DCOS\mesos\mesos\3rdparty\libprocess\include\process/ssl/gtest.hpp(355): error C3861: 'realpath': identifier not found (compiling source file C:\DCOS\mesos\mesos\3rdparty\libprocess\src\tests\ssl_tests.cpp) [C:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj]
96 Warning(s)
6 Error(s)
Time Elapsed 00:04:26.85
```
- [libprocess-tests-CMakeOutput.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64226/logs/libprocess-tests-CMakeOutput.log):
```
Creating directory "C:\DCOS\mesos\CMakeFiles\CMakeTmp\Debug\".
Creating directory "cmTC_e0d77.dir\Debug\cmTC_e0d77.tlog\".
InitializeBuildStatus:
Creating "cmTC_e0d77.dir\Debug\cmTC_e0d77.tlog\unsuccessfulbuild" because "AlwaysCreate" was specified.
ClCompile:
C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.10.25017\bin\HostX64\x64\CL.exe /c /Zi /W3 /WX- /diagnostics:classic /Od /Ob0 /D WIN32 /D _WINDOWS /D COMPILER_SUPPORTS_CXX11 /D "CMAKE_INTDIR=\"Debug\"" /D _MBCS /Gm- /EHsc /RTC1 /MDd /GS /fp:precise /Zc:wchar_t /Zc:forScope /Zc:inline /GR /Fo"cmTC_e0d77.dir\Debug\" /Fd"cmTC_e0d77.dir\Debug\vc141.pdb" /Gd /TP /errorReport:queue C:\DCOS\mesos\CMakeFiles\CMakeTmp\src.cxx
Microsoft (R) C/C++ Optimizing Compiler Version 19.10.25019 for x64
Copyright (C) Microsoft Corporation. All rights reserved.
cl /c /Zi /W3 /WX- /diagnostics:classic /Od /Ob0 /D WIN32 /D _WINDOWS /D COMPILER_SUPPORTS_CXX11 /D "CMAKE_INTDIR=\"Debug\"" /D _MBCS /Gm- /EHsc /RTC1 /MDd /GS /fp:precise /Zc:wchar_t /Zc:forScope /Zc:inline /GR /Fo"cmTC_e0d77.dir\Debug\" /Fd"cmTC_e0d77.dir\Debug\vc141.pdb" /Gd /TP /errorReport:queue C:\DCOS\mesos\CMakeFiles\CMakeTmp\src.cxx
src.cxx
Link:
C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.10.25017\bin\HostX64\x64\link.exe /ERRORREPORT:QUEUE /OUT:"C:\DCOS\mesos\CMakeFiles\CMakeTmp\Debug\cmTC_e0d77.exe" /INCREMENTAL /NOLOGO kernel32.lib user32.lib gdi32.lib winspool.lib shell32.lib ole32.lib oleaut32.lib uuid.lib comdlg32.lib advapi32.lib /MANIFEST /MANIFESTUAC:"level='asInvoker' uiAccess='false'" /manifest:embed /DEBUG /PDB:"C:/DCOS/mesos/CMakeFiles/CMakeTmp/Debug/cmTC_e0d77.pdb" /SUBSYSTEM:CONSOLE /TLBID:1 /DYNAMICBASE /NXCOMPAT /IMPLIB:"C:/DCOS/mesos/CMakeFiles/CMakeTmp/Debug/cmTC_e0d77.lib" /MACHINE:X64 /machine:x64 cmTC_e0d77.dir\Debug\src.obj
cmTC_e0d77.vcxproj -> C:\DCOS\mesos\CMakeFiles\CMakeTmp\Debug\cmTC_e0d77.exe
cmTC_e0d77.vcxproj -> C:/DCOS/mesos/CMakeFiles/CMakeTmp/Debug/cmTC_e0d77.pdb (Full PDB)
FinalizeBuildStatus:
Deleting file "cmTC_e0d77.dir\Debug\cmTC_e0d77.tlog\unsuccessfulbuild".
Touching "cmTC_e0d77.dir\Debug\cmTC_e0d77.tlog\cmTC_e0d77.lastbuildstate".
Done Building Project "C:\DCOS\mesos\CMakeFiles\CMakeTmp\cmTC_e0d77.vcxproj" (default targets).
Build succeeded.
0 Warning(s)
0 Error(s)
Time Elapsed 00:00:01.82
Source file was:
int main() { return 0; }
```
- [libprocess-tests-CMakeError.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64226/logs/libprocess-tests-CMakeError.log):
```
PrepareForBuild:
Creating directory "cmTC_7d048.dir\Debug\".
Creating directory "C:\DCOS\mesos\CMakeFiles\CMakeTmp\Debug\".
Creating directory "cmTC_7d048.dir\Debug\cmTC_7d048.tlog\".
InitializeBuildStatus:
Creating "cmTC_7d048.dir\Debug\cmTC_7d048.tlog\unsuccessfulbuild" because "AlwaysCreate" was specified.
ClCompile:
C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.10.25017\bin\HostX64\x64\CL.exe /c /Zi /W3 /WX- /diagnostics:classic /MP /Od /Ob0 /D WIN32 /D _WINDOWS /D UNICODE /D _UNICODE /D "CMAKE_INTDIR=\"Debug\"" /D _UNICODE /D UNICODE /Gm- /RTC1 /MTd /GS /fp:precise /Zc:wchar_t /Zc:forScope /Zc:inline /Fo"cmTC_7d048.dir\Debug\" /Fd"cmTC_7d048.dir\Debug\vc141.pdb" /Gd /TC /errorReport:queue C:\DCOS\mesos\CMakeFiles\CMakeTmp\CheckIncludeFile.c
Microsoft (R) C/C++ Optimizing Compiler Version 19.10.25019 for x64
Copyright (C) Microsoft Corporation. All rights reserved.
cl /c /Zi /W3 /WX- /diagnostics:classic /MP /Od /Ob0 /D WIN32 /D _WINDOWS /D UNICODE /D _UNICODE /D "CMAKE_INTDIR=\"Debug\"" /D _UNICODE /D UNICODE /Gm- /RTC1 /MTd /GS /fp:precise /Zc:wchar_t /Zc:forScope /Zc:inline /Fo"cmTC_7d048.dir\Debug\" /Fd"cmTC_7d048.dir\Debug\vc141.pdb" /Gd /TC /errorReport:queue C:\DCOS\mesos\CMakeFiles\CMakeTmp\CheckIncludeFile.c
CheckIncludeFile.c
C:\DCOS\mesos\CMakeFiles\CMakeTmp\CheckIncludeFile.c(1): fatal error C1083: Cannot open include file: 'pthread.h': No such file or directory [C:\DCOS\mesos\CMakeFiles\CMakeTmp\cmTC_7d048.vcxproj]
Done Building Project "C:\DCOS\mesos\CMakeFiles\CMakeTmp\cmTC_7d048.vcxproj" (default targets) -- FAILED.
Build FAILED.
"C:\DCOS\mesos\CMakeFiles\CMakeTmp\cmTC_7d048.vcxproj" (default target) (1) ->
(ClCompile target) ->
C:\DCOS\mesos\CMakeFiles\CMakeTmp\CheckIncludeFile.c(1): fatal error C1083: Cannot open include file: 'pthread.h': No such file or directory [C:\DCOS\mesos\CMakeFiles\CMakeTmp\cmTC_7d048.vcxproj]
0 Warning(s)
1 Error(s)
Time Elapsed 00:00:01.14
```
- Mesos Reviewbot Windows
On Nov. 30, 2017, 10:03 p.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64226/
> -----------------------------------------------------------
>
> (Updated Nov. 30, 2017, 10:03 p.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Bugs: MESOS-8284
> https://issues.apache.org/jira/browse/MESOS-8284
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a `ns::supported` convenience API which directly expresses the
> intent to probe whether a specific Linux namespace is supported on
> the running kernel and takes care of kernel versioning special cases.
>
>
> Diffs
> -----
>
> src/linux/ns.hpp e24d79a41eefcade343b2825b5a758d7d30a5f91
> src/linux/ns.cpp 5e2df1ed56432c6c1bfa04a31dba7f9f547d6139
> src/slave/containerizer/mesos/isolators/namespaces/ipc.cpp 2d89d598d24e3bcf01d652ce3f586c9e3ccfc20b
> src/slave/containerizer/mesos/isolators/namespaces/pid.cpp 4f8253b58018581e022eb1832b9b07703cbd318d
> src/slave/containerizer/mesos/isolators/network/port_mapping.cpp d60052e9e1ccdfaaac6c0db6acfdae325cea6a9e
> src/tests/containerizer/ns_tests.cpp 61adf8525b1df1a70d7fd9c747d2106630a7627d
>
>
> Diff: https://reviews.apache.org/r/64226/diff/2/
>
>
> Testing
> -------
>
> make check (Fedora 27)
>
>
> Thanks,
>
> James Peach
>
>
Re: Review Request 64226: Added a `ns::supported` convenience API.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64226/#review198248
-----------------------------------------------------------
FAIL: Some of the unit tests failed. Please check the relevant logs.
Reviews applied: `['64226']`
Failed command: `Start-MesosCITesting`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64226
Relevant logs:
- [stout-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64226/logs/stout-tests-stdout.log):
```
[ RUN ] RmdirTest.SYMLINK_RemoveDirectoryWithSymbolicLinkTargetFile
[ OK ] RmdirTest.SYMLINK_RemoveDirectoryWithSymbolicLinkTargetFile (4 ms)
[ RUN ] RmdirTest.RemoveDirectoryButPreserveRoot
[ OK ] RmdirTest.RemoveDirectoryButPreserveRoot (5 ms)
[----------] 11 tests from RmdirTest (52 ms total)
[----------] 1 test from SocketTests
[ RUN ] SocketTests.InitSocket
[ OK ] SocketTests.InitSocket (1 ms)
[----------] 1 test from SocketTests (2 ms total)
[----------] 2 tests from StrerrorTest
[ RUN ] StrerrorTest.ValidErrno
[ OK ] StrerrorTest.ValidErrno (0 ms)
[ RUN ] StrerrorTest.InvalidErrno
[ OK ] StrerrorTest.InvalidErrno (0 ms)
[----------] 2 tests from StrerrorTest (2 ms total)
[----------] Global test environment tear-down
[==========] 273 tests from 46 test cases ran. (4259 ms total)
[ PASSED ] 270 tests.
[ FAILED ] 3 tests, listed below:
[ FAILED ] OsTest.SYMLINK_Realpath
[ FAILED ] FsTest.CreateDirectoryAtMaxPath
[ FAILED ] FsTest.CreateDirectoryLongerThanMaxPath
3 FAILED TESTS
YOU HAVE 7 DISABLED TESTS
```
- [stout-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64226/logs/stout-tests-stderr.log):
```
'invalid.command' is not recognized as an internal or external command,
operable program or batch file.
Subcommand 'subcommand' is not available
Usage: command <subcommand> [OPTIONS]
Available subcommands:
help
subcommand2
Multiple subcommands have name 'subcommand'
```
- [mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64226/logs/mesos-tests-stdout.log):
```
[ OK ] Endpoint/SlaveEndpointTest.NoAuthorizer/2 (98 ms)
[----------] 9 tests from Endpoint/SlaveEndpointTest (920 ms total)
[----------] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest
[ RUN ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0
[ OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0 (33 ms)
[ RUN ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1
[ OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1 (37 ms)
[----------] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest (71 ms total)
[----------] 1 test from IsolationFlag/CpuIsolatorTest
[ RUN ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0
[ OK ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0 (2145 ms)
[----------] 1 test from IsolationFlag/CpuIsolatorTest (2167 ms total)
[----------] 1 test from IsolationFlag/MemoryIsolatorTest
[ RUN ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0
[ OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (2270 ms)
[----------] 1 test from IsolationFlag/MemoryIsolatorTest (2292 ms total)
[----------] Global test environment tear-down
[==========] 914 tests from 90 test cases ran. (408828 ms total)
[ PASSED ] 913 tests.
[ FAILED ] 1 test, listed below:
[ FAILED ] FilesTest.DebugTest
1 FAILED TEST
YOU HAVE 211 DISABLED TESTS
```
- [mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64226/logs/mesos-tests-stderr.log):
```
I0224 03:59:35.364686 7040 master.cpp:10258] Updating the state of task 1059220c-2489-4b2f-9d6e-90dfe9c2a62b of framework 5495faf4-2635-4db8-8011-7e84191b8829-0000 (latest state: TASK_KILLED, status update state: TASK_KILLED)
I0224 03:59:35.364686 1100 slave.cpp:3879] Shutting down framework 5495faf4-2635-4db8-8011-7e84191b8829-0000
I0224 03:59:35.365685 1100 slave.cpp:6586] Shutting down executor '1059220c-2489-4b2f-9d6e-90dfe9c2a62b' of framework 5495faf4-2635-4db8-8011-7e84191b8829-0000 at executor(1)@10.3.1.5:59961
I0224 03:59:35.365685 1100 slave.cpp:922] Agent terminating
W0224 03:59:35.365685 1100 slave.cpp:3875] Ignoring shutdown framework 5495faf4-2635-4db8-I0224 03:59:34.712641 4684 exec.cpp:162] Version: 1.6.0
I0224 03:59:34.736641 8352 exec.cpp:236] Executor registered on agent 5495faf4-2635-4db8-8011-7e84191b8829-S0
I0224 03:59:34.740639 2900 executor.cpp:174] Received SUBSCRIBED event
I0224 03:59:34.744666 2900 executor.cpp:178] Subscribed executor on build-srv-04.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net
I0224 03:59:34.744666 2900 executor.cpp:174] Received LAUNCH event
I0224 03:59:34.749668 2900 executor.cpp:646] Starting task 1059220c-2489-4b2f-9d6e-90dfe9c2a62b
I0224 03:59:34.831645 2900 executor.cpp:481] Running 'D:\DCOS\mesos\src\mesos-containerizer.exe launch <POSSIBLY-SENSITIVE-DATA>'
I0224 03:59:35.338959 2900 executor.cpp:659] Forked command at 9340
I0224 03:59:35.366659 7232 exec.cpp:445] Executor asked to shutdown
I0224 03:59:35.366659 7864 executor.cpp:174] Received SHUTDOWN event
I0224 03:59:35.366659 7864 executor.cpp:756] Shutting down
I0224 03:59:35.367660 7864 executor.cpp:866] Sending SIGTERM to process tree at pid 98011-7e84191b8829-0000 because it is terminating
I0224 03:59:35.367660 7040 master.cpp:10357] Removing task 1059220c-2489-4b2f-9d6e-90dfe9c2a62b with resources cpus(allocated: *):4; mem(allocated: *):2048; disk(allocated: *):1024; ports(allocated: *):[31000-32000] of framework 5495faf4-2635-4db8-8011-7e84191b8829-0000 on agent 5495faf4-2635-4db8-8011-7e84191b8829-S0 at slave(398)@10.3.1.5:59939 (build-srv-04.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0224 03:59:35.369659 4740 containerizer.cpp:2338] Destroying container fbcdd256-e196-409c-9a8b-f04f26a012e0 in RUNNING state
I0224 03:59:35.369659 4740 containerizer.cpp:2952] Transitioning the state of container fbcdd256-e196-409c-9a8b-f04f26a012e0 from RUNNING to DESTROYING
I0224 03:59:35.370661 7040 master.cpp:1306] Agent 5495faf4-2635-4db8-8011-7e84191b8829-S0 at slave(398)@10.3.1.5:59939 (build-srv-04.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net) disconnected
I0224 03:59:35.370661 7040 master.cpp:3276] Disconnecting agent 5495faf4-2635-4db8-8011-7e84191b8829-S0 at slave(398)@10.3.1.5:59939 (build-srv-04.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0224 03:59:35.370661 4740 launcher.cpp:156] Asked to destroy container fbcdd256-e196-409c-9a8b-f04f26a012e0
I0224 03:59:35.370661 8600 hierarchical.cpp:344] Removed framework 5495faf4-2635-4db8-8011-7e84191b8829-0000
I0224 03:59:35.370661 7040 master.cpp:3295] Deactivating agent 5495faf4-2635-4db8-8011-7e84191b8829-S0 at slave(398)@10.3.1.5:59939 (build-srv-04.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0224 03:59:35.371660 3656 hierarchical.cpp:766] Agent 5495faf4-2635-4db8-8011-7e84191b8829-S0 deactivated
I0224 03:59:35.487448 3656 containerizer.cpp:2791] Container fbcdd256-e196-409c-9a8b-f04f26a012e0 has exited
I0224 03:59:35.516455 3120 master.cpp:1149] Master terminating
I0224 03:59:35.518483 9644 hierarchical.cpp:609] Removed agent 5495faf4-2635-4db8-8011-7e84191b8829-S0
I0224 03:59:35.976886 6380 process.cpp:929] Stopped the socket accept loop
```
- Mesos Reviewbot Windows
On Dec. 1, 2017, 3:46 p.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64226/
> -----------------------------------------------------------
>
> (Updated Dec. 1, 2017, 3:46 p.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Bugs: MESOS-8284
> https://issues.apache.org/jira/browse/MESOS-8284
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a `ns::supported` convenience API which directly expresses the
> intent to probe whether a specific Linux namespace is supported on
> the running kernel and takes care of kernel versioning special cases.
>
> This API subsumes the previous usages of `ns::namespaces`, so that API
> is now used only retained as an internal helper.
>
>
> Diffs
> -----
>
> src/linux/ns.hpp 8b6406754340d5bc244047a9d8c9fad5cead8f4d
> src/linux/ns.cpp 49f8fca5884da7425f2fed5e8b598ef7cc4dc6e1
> src/slave/containerizer/mesos/isolators/namespaces/ipc.cpp 90773d7b237ac83899d161ab251b4eecda02b3b9
> src/slave/containerizer/mesos/isolators/namespaces/pid.cpp d765929c2d5133ad5eac9f8a6c4d68ceda922eea
> src/slave/containerizer/mesos/isolators/network/port_mapping.cpp d60052e9e1ccdfaaac6c0db6acfdae325cea6a9e
> src/tests/containerizer/ns_tests.cpp 61adf8525b1df1a70d7fd9c747d2106630a7627d
> src/tests/containerizer/setns_test_helper.cpp 045caf684baf6e724fa5f99b6cc3feeb87817ba3
>
>
> Diff: https://reviews.apache.org/r/64226/diff/6/
>
>
> Testing
> -------
>
> make check (Fedora 27)
>
>
> Thanks,
>
> James Peach
>
>
Re: Review Request 64226: Added a `ns::supported` convenience API.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64226/#review198241
-----------------------------------------------------------
FAIL: Some of the unit tests failed. Please check the relevant logs.
Reviews applied: `['64226']`
Failed command: `Start-MesosCITesting`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64226
Relevant logs:
- [stout-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64226/logs/stout-tests-stdout.log):
```
[ RUN ] RmdirTest.SYMLINK_RemoveDirectoryWithSymbolicLinkTargetFile
[ OK ] RmdirTest.SYMLINK_RemoveDirectoryWithSymbolicLinkTargetFile (4 ms)
[ RUN ] RmdirTest.RemoveDirectoryButPreserveRoot
[ OK ] RmdirTest.RemoveDirectoryButPreserveRoot (5 ms)
[----------] 11 tests from RmdirTest (49 ms total)
[----------] 1 test from SocketTests
[ RUN ] SocketTests.InitSocket
[ OK ] SocketTests.InitSocket (1 ms)
[----------] 1 test from SocketTests (2 ms total)
[----------] 2 tests from StrerrorTest
[ RUN ] StrerrorTest.ValidErrno
[ OK ] StrerrorTest.ValidErrno (0 ms)
[ RUN ] StrerrorTest.InvalidErrno
[ OK ] StrerrorTest.InvalidErrno (0 ms)
[----------] 2 tests from StrerrorTest (2 ms total)
[----------] Global test environment tear-down
[==========] 273 tests from 46 test cases ran. (4138 ms total)
[ PASSED ] 270 tests.
[ FAILED ] 3 tests, listed below:
[ FAILED ] OsTest.SYMLINK_Realpath
[ FAILED ] FsTest.CreateDirectoryAtMaxPath
[ FAILED ] FsTest.CreateDirectoryLongerThanMaxPath
3 FAILED TESTS
YOU HAVE 7 DISABLED TESTS
```
- [stout-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64226/logs/stout-tests-stderr.log):
```
'invalid.command' is not recognized as an internal or external command,
operable program or batch file.
Subcommand 'subcommand' is not available
Usage: command <subcommand> [OPTIONS]
Available subcommands:
help
subcommand2
Multiple subcommands have name 'subcommand'
```
- [mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64226/logs/mesos-tests-stdout.log):
```
[ OK ] Endpoint/SlaveEndpointTest.NoAuthorizer/2 (104 ms)
[----------] 9 tests from Endpoint/SlaveEndpointTest (941 ms total)
[----------] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest
[ RUN ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0
[ OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0 (39 ms)
[ RUN ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1
[ OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1 (42 ms)
[----------] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest (83 ms total)
[----------] 1 test from IsolationFlag/CpuIsolatorTest
[ RUN ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0
[ OK ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0 (2152 ms)
[----------] 1 test from IsolationFlag/CpuIsolatorTest (2174 ms total)
[----------] 1 test from IsolationFlag/MemoryIsolatorTest
[ RUN ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0
[ OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (2265 ms)
[----------] 1 test from IsolationFlag/MemoryIsolatorTest (2286 ms total)
[----------] Global test environment tear-down
[==========] 912 tests from 90 test cases ran. (401596 ms total)
[ PASSED ] 911 tests.
[ FAILED ] 1 test, listed below:
[ FAILED ] FilesTest.DebugTest
1 FAILED TEST
YOU HAVE 211 DISABLED TESTS
```
- [mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64226/logs/mesos-tests-stderr.log):
```
I0224 02:27:00.366788 6516 slave.cpp:3879] Shutting down framework 6cf16fe6-43dd-460f-b8be-1c925d723cce-0000
I0224 02:27:00.366788 10236 master.cpp:10248] Updating the state of task 5320fa4b-5c3a-4a5a-82b6-77cf18849108 of framework 6cf16fe6-43dd-460f-b8be-1c925d723cce-0000 (latest state: TASK_KILLED, status update state: TASK_KILLED)
I0224 02:27:00.366788 6516 slave.cpp:6586] Shutting down executor '5320fa4b-5c3a-4a5a-82b6-77cf18849108' of framework 6cf16fe6-43dd-460f-b8be-1c925d723cce-0000 at executor(1)@10.3.1.5:55480
I0224 02:27:00.367931 6516 slave.cpp:922] Agent terminating
W0224 02:27:00.369148 6516 slave.cpp:3875] IgnoriI0224 02:26:59.718770 3544 exec.cpp:162] Version: 1.6.0
I0224 02:26:59.751807 7352 exec.cpp:236] Executor registered on agent 6cf16fe6-43dd-460f-b8be-1c925d723cce-S0
I0224 02:26:59.755766 5084 executor.cpp:174] Received SUBSCRIBED event
I0224 02:26:59.759766 5084 executor.cpp:178] Subscribed executor on build-srv-04.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net
I0224 02:26:59.759766 5084 executor.cpp:174] Received LAUNCH event
I0224 02:26:59.765765 5084 executor.cpp:646] Starting task 5320fa4b-5c3a-4a5a-82b6-77cf18849108
I0224 02:26:59.845770 5084 executor.cpp:481] Running 'D:\DCOS\mesos\src\mesos-containerizer.exe launch <POSSIBLY-SENSITIVE-DATA>'
I0224 02:27:00.337843 5084 executor.cpp:659] Forked command at 7908
I0224 02:27:00.367931 4596 exec.cpp:445] Executor asked to shutdown
I0224 02:27:00.369148 2924 executor.cpp:174] Received SHUTDOWN event
I0224 02:27:00.369148 2924 executor.cpp:756] Shutting down
I0224 02:27:00.369148 2924 executor.cpp:866] Sending SIGTERM to process tree at pid 7ng shutdown framework 6cf16fe6-43dd-460f-b8be-1c925d723cce-0000 because it is terminating
I0224 02:27:00.371160 10236 master.cpp:10347] Removing task 5320fa4b-5c3a-4a5a-82b6-77cf18849108 with resources cpus(allocated: *):4; mem(allocated: *):2048; disk(allocated: *):1024; ports(allocated: *):[31000-32000] of framework 6cf16fe6-43dd-460f-b8be-1c925d723cce-0000 on agent 6cf16fe6-43dd-460f-b8be-1c925d723cce-S0 at slave(396)@10.3.1.5:55458 (build-srv-04.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0224 02:27:00.373785 10236 master.cpp:1306] Agent 6cf16fe6-43dd-460f-b8be-1c925d723cce-S0 at slave(396)@10.3.1.5:55458 (build-srv-04.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net) disconnected
I0224 02:27:00.373785 3644 containerizer.cpp:2338] Destroying container e1f5557e-5251-4d05-9466-0804f6e53493 in RUNNING state
I0224 02:27:00.373785 10236 master.cpp:3276] Disconnecting agent 6cf16fe6-43dd-460f-b8be-1c925d723cce-S0 at slave(396)@10.3.1.5:55458 (build-srv-04.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0224 02:27:00.373785 4280 hierarchical.cpp:344] Removed framework 6cf16fe6-43dd-460f-b8be-1c925d723cce-0000
I0224 02:27:00.373785 3644 containerizer.cpp:2952] Transitioning the state of container e1f5557e-5251-4d05-9466-0804f6e53493 from RUNNING to DESTROYING
I0224 02:27:00.374847 10236 master.cpp:3295] Deactivating agent 6cf16fe6-43dd-460f-b8be-1c925d723cce-S0 at slave(396)@10.3.1.5:55458 (build-srv-04.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0224 02:27:00.374847 6516 hierarchical.cpp:766] Agent 6cf16fe6-43dd-460f-b8be-1c925d723cce-S0 deactivated
I0224 02:27:00.374847 3644 launcher.cpp:156] Asked to destroy container e1f5557e-5251-4d05-9466-0804f6e53493
I0224 02:27:00.426904 7488 containerizer.cpp:2791] Container e1f5557e-5251-4d05-9466-0804f6e53493 has exited
I0224 02:27:00.455916 7232 master.cpp:1149] Master terminating
I0224 02:27:00.457916 4280 hierarchical.cpp:609] Removed agent 6cf16fe6-43dd-460f-b8be-1c925d723cce-S0
I0224 02:27:00.923763 7648 process.cpp:929] Stopped the socket accept loop
```
- Mesos Reviewbot Windows
On Dec. 1, 2017, 11:46 p.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64226/
> -----------------------------------------------------------
>
> (Updated Dec. 1, 2017, 11:46 p.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Bugs: MESOS-8284
> https://issues.apache.org/jira/browse/MESOS-8284
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a `ns::supported` convenience API which directly expresses the
> intent to probe whether a specific Linux namespace is supported on
> the running kernel and takes care of kernel versioning special cases.
>
> This API subsumes the previous usages of `ns::namespaces`, so that API
> is now used only retained as an internal helper.
>
>
> Diffs
> -----
>
> src/linux/ns.hpp 8b6406754340d5bc244047a9d8c9fad5cead8f4d
> src/linux/ns.cpp 49f8fca5884da7425f2fed5e8b598ef7cc4dc6e1
> src/slave/containerizer/mesos/isolators/namespaces/ipc.cpp 90773d7b237ac83899d161ab251b4eecda02b3b9
> src/slave/containerizer/mesos/isolators/namespaces/pid.cpp d765929c2d5133ad5eac9f8a6c4d68ceda922eea
> src/slave/containerizer/mesos/isolators/network/port_mapping.cpp d60052e9e1ccdfaaac6c0db6acfdae325cea6a9e
> src/tests/containerizer/ns_tests.cpp 61adf8525b1df1a70d7fd9c747d2106630a7627d
> src/tests/containerizer/setns_test_helper.cpp 045caf684baf6e724fa5f99b6cc3feeb87817ba3
>
>
> Diff: https://reviews.apache.org/r/64226/diff/5/
>
>
> Testing
> -------
>
> make check (Fedora 27)
>
>
> Thanks,
>
> James Peach
>
>
Re: Review Request 64226: Added a `ns::supported` convenience API.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64226/#review198232
-----------------------------------------------------------
FAIL: Failed to apply the current review.
Failed command: `python.exe .\support\apply-reviews.py -n -r 64226`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64226
Relevant logs:
- [apply-review-64226-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64226/logs/apply-review-64226-stdout.log):
```
*** Please tell me who you are.
Run
git config --global user.email "you@example.com"
git config --global user.name "Your Name"
to set your account's default identity.
Omit --global to set the identity only in this repository.
fatal: unable to auto-detect email address (got 'SYSTEM@build-srv-04.(none)')
```
- Mesos Reviewbot Windows
On Dec. 1, 2017, 11:46 p.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64226/
> -----------------------------------------------------------
>
> (Updated Dec. 1, 2017, 11:46 p.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Bugs: MESOS-8284
> https://issues.apache.org/jira/browse/MESOS-8284
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a `ns::supported` convenience API which directly expresses the
> intent to probe whether a specific Linux namespace is supported on
> the running kernel and takes care of kernel versioning special cases.
>
> This API subsumes the previous usages of `ns::namespaces`, so that API
> is now used only retained as an internal helper.
>
>
> Diffs
> -----
>
> src/linux/ns.hpp e24d79a41eefcade343b2825b5a758d7d30a5f91
> src/linux/ns.cpp 5e2df1ed56432c6c1bfa04a31dba7f9f547d6139
> src/slave/containerizer/mesos/isolators/namespaces/ipc.cpp 2d89d598d24e3bcf01d652ce3f586c9e3ccfc20b
> src/slave/containerizer/mesos/isolators/namespaces/pid.cpp 4f8253b58018581e022eb1832b9b07703cbd318d
> src/slave/containerizer/mesos/isolators/network/port_mapping.cpp d60052e9e1ccdfaaac6c0db6acfdae325cea6a9e
> src/tests/containerizer/ns_tests.cpp 61adf8525b1df1a70d7fd9c747d2106630a7627d
> src/tests/containerizer/setns_test_helper.cpp 045caf684baf6e724fa5f99b6cc3feeb87817ba3
>
>
> Diff: https://reviews.apache.org/r/64226/diff/4/
>
>
> Testing
> -------
>
> make check (Fedora 27)
>
>
> Thanks,
>
> James Peach
>
>
Re: Review Request 64226: Added a `ns::supported` convenience API.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64226/#review198231
-----------------------------------------------------------
Fix it, then Ship it!
LGTM
src/linux/ns.cpp
Lines 158 (patched)
<https://reviews.apache.org/r/64226/#comment278342>
nits: we don't use `&` for primitive types, `const int n`.
- Jie Yu
On Dec. 1, 2017, 11:46 p.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64226/
> -----------------------------------------------------------
>
> (Updated Dec. 1, 2017, 11:46 p.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Bugs: MESOS-8284
> https://issues.apache.org/jira/browse/MESOS-8284
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a `ns::supported` convenience API which directly expresses the
> intent to probe whether a specific Linux namespace is supported on
> the running kernel and takes care of kernel versioning special cases.
>
> This API subsumes the previous usages of `ns::namespaces`, so that API
> is now used only retained as an internal helper.
>
>
> Diffs
> -----
>
> src/linux/ns.hpp e24d79a41eefcade343b2825b5a758d7d30a5f91
> src/linux/ns.cpp 5e2df1ed56432c6c1bfa04a31dba7f9f547d6139
> src/slave/containerizer/mesos/isolators/namespaces/ipc.cpp 2d89d598d24e3bcf01d652ce3f586c9e3ccfc20b
> src/slave/containerizer/mesos/isolators/namespaces/pid.cpp 4f8253b58018581e022eb1832b9b07703cbd318d
> src/slave/containerizer/mesos/isolators/network/port_mapping.cpp d60052e9e1ccdfaaac6c0db6acfdae325cea6a9e
> src/tests/containerizer/ns_tests.cpp 61adf8525b1df1a70d7fd9c747d2106630a7627d
> src/tests/containerizer/setns_test_helper.cpp 045caf684baf6e724fa5f99b6cc3feeb87817ba3
>
>
> Diff: https://reviews.apache.org/r/64226/diff/4/
>
>
> Testing
> -------
>
> make check (Fedora 27)
>
>
> Thanks,
>
> James Peach
>
>
Re: Review Request 64226: Added a `ns::supported` convenience API.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64226/#review198249
-----------------------------------------------------------
Patch looks great!
Reviews applied: [64226]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Dec. 1, 2017, 3:46 p.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64226/
> -----------------------------------------------------------
>
> (Updated Dec. 1, 2017, 3:46 p.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Bugs: MESOS-8284
> https://issues.apache.org/jira/browse/MESOS-8284
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a `ns::supported` convenience API which directly expresses the
> intent to probe whether a specific Linux namespace is supported on
> the running kernel and takes care of kernel versioning special cases.
>
> This API subsumes the previous usages of `ns::namespaces`, so that API
> is now used only retained as an internal helper.
>
>
> Diffs
> -----
>
> src/linux/ns.hpp 8b6406754340d5bc244047a9d8c9fad5cead8f4d
> src/linux/ns.cpp 49f8fca5884da7425f2fed5e8b598ef7cc4dc6e1
> src/slave/containerizer/mesos/isolators/namespaces/ipc.cpp 90773d7b237ac83899d161ab251b4eecda02b3b9
> src/slave/containerizer/mesos/isolators/namespaces/pid.cpp d765929c2d5133ad5eac9f8a6c4d68ceda922eea
> src/slave/containerizer/mesos/isolators/network/port_mapping.cpp d60052e9e1ccdfaaac6c0db6acfdae325cea6a9e
> src/tests/containerizer/ns_tests.cpp 61adf8525b1df1a70d7fd9c747d2106630a7627d
> src/tests/containerizer/setns_test_helper.cpp 045caf684baf6e724fa5f99b6cc3feeb87817ba3
>
>
> Diff: https://reviews.apache.org/r/64226/diff/6/
>
>
> Testing
> -------
>
> make check (Fedora 27)
>
>
> Thanks,
>
> James Peach
>
>
Re: Review Request 64226: Added a `ns::supported` convenience API.
Posted by James Peach <jp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64226/
-----------------------------------------------------------
(Updated Dec. 1, 2017, 11:46 p.m.)
Review request for mesos and Jie Yu.
Changes
-------
Address review feedback.
Bugs: MESOS-8284
https://issues.apache.org/jira/browse/MESOS-8284
Repository: mesos
Description (updated)
-------
Added a `ns::supported` convenience API which directly expresses the
intent to probe whether a specific Linux namespace is supported on
the running kernel and takes care of kernel versioning special cases.
This API subsumes the previous usages of `ns::namespaces`, so that API
is now used only retained as an internal helper.
Diffs (updated)
-----
src/linux/ns.hpp e24d79a41eefcade343b2825b5a758d7d30a5f91
src/linux/ns.cpp 5e2df1ed56432c6c1bfa04a31dba7f9f547d6139
src/slave/containerizer/mesos/isolators/namespaces/ipc.cpp 2d89d598d24e3bcf01d652ce3f586c9e3ccfc20b
src/slave/containerizer/mesos/isolators/namespaces/pid.cpp 4f8253b58018581e022eb1832b9b07703cbd318d
src/slave/containerizer/mesos/isolators/network/port_mapping.cpp d60052e9e1ccdfaaac6c0db6acfdae325cea6a9e
src/tests/containerizer/ns_tests.cpp 61adf8525b1df1a70d7fd9c747d2106630a7627d
src/tests/containerizer/setns_test_helper.cpp 045caf684baf6e724fa5f99b6cc3feeb87817ba3
Diff: https://reviews.apache.org/r/64226/diff/3/
Changes: https://reviews.apache.org/r/64226/diff/2-3/
Testing
-------
make check (Fedora 27)
Thanks,
James Peach
Re: Review Request 64226: Added a `ns::supported` convenience API.
Posted by James Peach <jp...@apache.org>.
> On Dec. 1, 2017, 12:07 a.m., Jie Yu wrote:
> > src/linux/ns.hpp
> > Lines 99 (patched)
> > <https://reviews.apache.org/r/64226/diff/2/?file=1904998#file1904998line99>
> >
> > Can you add some reason why there is a kernel version check there?
The reason is in the implementation. I'll move it here.
> On Dec. 1, 2017, 12:07 a.m., Jie Yu wrote:
> > src/linux/ns.cpp
> > Lines 136 (patched)
> > <https://reviews.apache.org/r/64226/diff/2/?file=1904999#file1904999line136>
> >
> > can you short circuit here if anything from `nsTypes` is not part of `nstypes()` so that we don't even go to the following user namespace kernel version check if user namespace is not even show up in `nstypes()`
> >
> > Then, you don't even need the final `return supported == nsTypes;`
Yup, will add. I'll retain `return supported == nsTypes` since we need that to check that all the requested types are supported.
> On Dec. 1, 2017, 12:07 a.m., Jie Yu wrote:
> > src/linux/ns.cpp
> > Lines 143 (patched)
> > <https://reviews.apache.org/r/64226/diff/2/?file=1904999#file1904999line143>
> >
> > We don't print glog warning in helpers. What if we want to use this in launch helper?
> >
> > I'd prefer return `Try<bool>`
Yeh I added the log because it would be bizarrely weird if the `uname` failed. I can switch to `Try`.
- James
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64226/#review192402
-----------------------------------------------------------
On Nov. 30, 2017, 10:03 p.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64226/
> -----------------------------------------------------------
>
> (Updated Nov. 30, 2017, 10:03 p.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Bugs: MESOS-8284
> https://issues.apache.org/jira/browse/MESOS-8284
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a `ns::supported` convenience API which directly expresses the
> intent to probe whether a specific Linux namespace is supported on
> the running kernel and takes care of kernel versioning special cases.
>
>
> Diffs
> -----
>
> src/linux/ns.hpp e24d79a41eefcade343b2825b5a758d7d30a5f91
> src/linux/ns.cpp 5e2df1ed56432c6c1bfa04a31dba7f9f547d6139
> src/slave/containerizer/mesos/isolators/namespaces/ipc.cpp 2d89d598d24e3bcf01d652ce3f586c9e3ccfc20b
> src/slave/containerizer/mesos/isolators/namespaces/pid.cpp 4f8253b58018581e022eb1832b9b07703cbd318d
> src/slave/containerizer/mesos/isolators/network/port_mapping.cpp d60052e9e1ccdfaaac6c0db6acfdae325cea6a9e
> src/tests/containerizer/ns_tests.cpp 61adf8525b1df1a70d7fd9c747d2106630a7627d
>
>
> Diff: https://reviews.apache.org/r/64226/diff/2/
>
>
> Testing
> -------
>
> make check (Fedora 27)
>
>
> Thanks,
>
> James Peach
>
>
Re: Review Request 64226: Added a `ns::supported` convenience API.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64226/#review192402
-----------------------------------------------------------
src/linux/ns.hpp
Lines 99 (patched)
<https://reviews.apache.org/r/64226/#comment270514>
Can you add some reason why there is a kernel version check there?
src/linux/ns.cpp
Lines 134 (patched)
<https://reviews.apache.org/r/64226/#comment270513>
indentation
src/linux/ns.cpp
Lines 136 (patched)
<https://reviews.apache.org/r/64226/#comment270515>
can you short circuit here if anything from `nsTypes` is not part of `nstypes()` so that we don't even go to the following user namespace kernel version check if user namespace is not even show up in `nstypes()`
Then, you don't even need the final `return supported == nsTypes;`
src/linux/ns.cpp
Lines 143 (patched)
<https://reviews.apache.org/r/64226/#comment270516>
We don't print glog warning in helpers. What if we want to use this in launch helper?
I'd prefer return `Try<bool>`
- Jie Yu
On Nov. 30, 2017, 10:03 p.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64226/
> -----------------------------------------------------------
>
> (Updated Nov. 30, 2017, 10:03 p.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Bugs: MESOS-8284
> https://issues.apache.org/jira/browse/MESOS-8284
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a `ns::supported` convenience API which directly expresses the
> intent to probe whether a specific Linux namespace is supported on
> the running kernel and takes care of kernel versioning special cases.
>
>
> Diffs
> -----
>
> src/linux/ns.hpp e24d79a41eefcade343b2825b5a758d7d30a5f91
> src/linux/ns.cpp 5e2df1ed56432c6c1bfa04a31dba7f9f547d6139
> src/slave/containerizer/mesos/isolators/namespaces/ipc.cpp 2d89d598d24e3bcf01d652ce3f586c9e3ccfc20b
> src/slave/containerizer/mesos/isolators/namespaces/pid.cpp 4f8253b58018581e022eb1832b9b07703cbd318d
> src/slave/containerizer/mesos/isolators/network/port_mapping.cpp d60052e9e1ccdfaaac6c0db6acfdae325cea6a9e
> src/tests/containerizer/ns_tests.cpp 61adf8525b1df1a70d7fd9c747d2106630a7627d
>
>
> Diff: https://reviews.apache.org/r/64226/diff/2/
>
>
> Testing
> -------
>
> make check (Fedora 27)
>
>
> Thanks,
>
> James Peach
>
>