[GitHub] [incubator-superset] etr2460 opened a new pull request #8734: [Explore] Fix annotation layer select box formatting

[GitBox <gi...@apache.org>]

etr2460 opened a new pull request #8734: [Explore] Fix annotation layer select box formatting
URL: https://github.com/apache/incubator-superset/pull/8734
 
 
   ### CATEGORY
   
   Choose one
   
   - [x] Bug Fix
   - [ ] Enhancement (new features, refinement)
   - [ ] Refactor
   - [ ] Add tests
   - [ ] Build / Development Environment
   - [ ] Documentation
   
   ### SUMMARY
   When rendering the annotation selector box, sometimes it was super jank looking because options were very verbose. This truncates the options and provides the full option on hover 
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   Before:
   <img width="250" alt="Screen Shot 2019-12-03 at 11 37 07 AM" src="https://user-images.githubusercontent.com/7409244/70083496-552b6480-15c1-11ea-8ede-ad580460a8e9.png">
   
   After:
   <img width="253" alt="Screen Shot 2019-12-03 at 11 28 56 AM" src="https://user-images.githubusercontent.com/7409244/70083502-59578200-15c1-11ea-97f8-648cffef45c9.png">
   
   ### TEST PLAN
   Make a chart with a really long name, view it in the annotation layer selector, see it truncated appropriately 
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [x] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   ### REVIEWERS
   @graceguo-supercat @betodealmeida @rusackas 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org