You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2025/02/20 20:28:27 UTC

[kudu-CR] [util] fix MetricsTest.TableAndTabletPrometheusTest

Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/22509


Change subject: [util] fix MetricsTest.TableAndTabletPrometheusTest
......................................................................

[util] fix MetricsTest.TableAndTabletPrometheusTest

Since different STL implementations might produce different ordering
in the metric entities' container (std::unordered_map), it was necessary
to amend the scenario to remove the hard-coded output template,
otherwise the scenario would fail at least on SLES15.

Change-Id: I15ee5fc8974f5df931a33cdcbc09c3da4da691a7
---
M src/kudu/util/metrics-test.cc
1 file changed, 42 insertions(+), 33 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/09/22509/1
-- 
To view, visit http://gerrit.cloudera.org:8080/22509
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I15ee5fc8974f5df931a33cdcbc09c3da4da691a7
Gerrit-Change-Number: 22509
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>

[kudu-CR] [util] fix MetricsTest.TableAndTabletPrometheusTest

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/22509 )

Change subject: [util] fix MetricsTest.TableAndTabletPrometheusTest
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/22509/1/src/kudu/util/metrics-test.cc
File src/kudu/util/metrics-test.cc:

http://gerrit.cloudera.org:8080/#/c/22509/1/src/kudu/util/metrics-test.cc@158
PS1, Line 158: 1111111111
> Is there a reason why the tablet lengths are different in this line and in 
The reason of this change is two-fold:
  * Have more reasonable formatting in the code
  * Have length variation in the entity names
  * Use identifiers different from the ones that Kudu master uses on its own

Do you have any particular corner case in mind that might be caught by the original code but not the modified code?

It seems the author of the original code copy-pasted the output from kudu-master metrics for the system tablet as-is when putting together this test scenario, but it doesn't bring any extra coverage, only making it's harder to format the strings in the code.  Even more: it would hide some issues when using the exact UUIDs that master uses for its system tablet if the metrics registry was shared between the test and the master's runtime.

As for catching corner cases: that's not the way to provide the desired coverage, IMO.  But I agree that there should be a test for various corner cases, along with a test to make sure the set of characters produced by our metrics is acceptable by Prometheus specs: https://prometheus.io/docs/concepts/data_model/#metric-names-and-labels



-- 
To view, visit http://gerrit.cloudera.org:8080/22509
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I15ee5fc8974f5df931a33cdcbc09c3da4da691a7
Gerrit-Change-Number: 22509
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Comment-Date: Mon, 24 Feb 2025 20:23:15 +0000
Gerrit-HasComments: Yes

[kudu-CR] [util] fix MetricsTest.TableAndTabletPrometheusTest

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22509 )

Change subject: [util] fix MetricsTest.TableAndTabletPrometheusTest
......................................................................


Patch Set 2:

Build Started http://jenkins.kudu.apache.org/job/pre_commit/1120/


-- 
To view, visit http://gerrit.cloudera.org:8080/22509
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I15ee5fc8974f5df931a33cdcbc09c3da4da691a7
Gerrit-Change-Number: 22509
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Comment-Date: Wed, 26 Feb 2025 05:54:36 +0000
Gerrit-HasComments: No

[kudu-CR] [util] fix MetricsTest.TableAndTabletPrometheusTest

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22509 )

Change subject: [util] fix MetricsTest.TableAndTabletPrometheusTest
......................................................................


Patch Set 1:

Build Started http://jenkins.kudu.apache.org/job/pre_commit/1096/


-- 
To view, visit http://gerrit.cloudera.org:8080/22509
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I15ee5fc8974f5df931a33cdcbc09c3da4da691a7
Gerrit-Change-Number: 22509
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 20 Feb 2025 20:28:37 +0000
Gerrit-HasComments: No

[kudu-CR] [util] fix MetricsTest.TableAndTabletPrometheusTest

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/22509 )

Change subject: [util] fix MetricsTest.TableAndTabletPrometheusTest
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/22509/1/src/kudu/util/metrics-test.cc
File src/kudu/util/metrics-test.cc:

http://gerrit.cloudera.org:8080/#/c/22509/1/src/kudu/util/metrics-test.cc@158
PS1, Line 158: 1111111111
> I see, makes sense. Maybe leave one at 32 character length? Just in case th
Yes, that's a valid concern.  And to address it there should be a test scenario for corner cases, as discussed.

Just to be clear: this particular test scenario isn't able catch an issue with Kudu metrics names being too long for Prometheus, and it wasn't able to catch that before this patch either.

Anyway, I added an extra table entity to have 32-symbol length name, as requested.  I'm not quite sure what it is for, but probably you have some extra concerns beyond those you've already articulated in prior comments.

Thanks!



-- 
To view, visit http://gerrit.cloudera.org:8080/22509
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I15ee5fc8974f5df931a33cdcbc09c3da4da691a7
Gerrit-Change-Number: 22509
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Comment-Date: Wed, 26 Feb 2025 05:54:56 +0000
Gerrit-HasComments: Yes

[kudu-CR] [util] fix MetricsTest.TableAndTabletPrometheusTest

Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/22509 )

Change subject: [util] fix MetricsTest.TableAndTabletPrometheusTest
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/22509/1/src/kudu/util/metrics-test.cc
File src/kudu/util/metrics-test.cc:

http://gerrit.cloudera.org:8080/#/c/22509/1/src/kudu/util/metrics-test.cc@158
PS1, Line 158: 1111111111
Is there a reason why the tablet lengths are different in this line and in line 154?
Also why not leave it at 32 characters? Maybe it might catch some corner cases?



-- 
To view, visit http://gerrit.cloudera.org:8080/22509
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I15ee5fc8974f5df931a33cdcbc09c3da4da691a7
Gerrit-Change-Number: 22509
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Comment-Date: Mon, 24 Feb 2025 19:28:58 +0000
Gerrit-HasComments: Yes

[kudu-CR] [util] fix MetricsTest.TableAndTabletPrometheusTest

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Marton Greber, Attila Bukor, Yifan Zhang, Kudu Jenkins, Abhishek Chennaka, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/22509

to look at the new patch set (#2).

Change subject: [util] fix MetricsTest.TableAndTabletPrometheusTest
......................................................................

[util] fix MetricsTest.TableAndTabletPrometheusTest

Since different STL implementations might produce different ordering
in the metric entities' container (std::unordered_map), it was necessary
to amend the scenario to remove the hard-coded output template,
otherwise the scenario would fail at least on SLES15.

Change-Id: I15ee5fc8974f5df931a33cdcbc09c3da4da691a7
---
M src/kudu/util/metrics-test.cc
1 file changed, 54 insertions(+), 33 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/09/22509/2
-- 
To view, visit http://gerrit.cloudera.org:8080/22509
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I15ee5fc8974f5df931a33cdcbc09c3da4da691a7
Gerrit-Change-Number: 22509
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>

[kudu-CR] [util] fix MetricsTest.TableAndTabletPrometheusTest

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22509 )

Change subject: [util] fix MetricsTest.TableAndTabletPrometheusTest
......................................................................


Patch Set 1: Verified-1

Build Failed 

http://jenkins.kudu.apache.org/job/pre_commit/1096/ : FAILURE


-- 
To view, visit http://gerrit.cloudera.org:8080/22509
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I15ee5fc8974f5df931a33cdcbc09c3da4da691a7
Gerrit-Change-Number: 22509
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Comment-Date: Thu, 20 Feb 2025 22:11:15 +0000
Gerrit-HasComments: No

[kudu-CR] [util] fix MetricsTest.TableAndTabletPrometheusTest

Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/22509 )

Change subject: [util] fix MetricsTest.TableAndTabletPrometheusTest
......................................................................


Patch Set 2: Code-Review+2

(1 comment)

http://gerrit.cloudera.org:8080/#/c/22509/1/src/kudu/util/metrics-test.cc
File src/kudu/util/metrics-test.cc:

http://gerrit.cloudera.org:8080/#/c/22509/1/src/kudu/util/metrics-test.cc@158
PS1, Line 158: 1111111111
> Yes, that's a valid concern.  And to address it there should be a test scen
Thanks for adding the new table entity. I guess we can add some more test cases in future for corner cases.



-- 
To view, visit http://gerrit.cloudera.org:8080/22509
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I15ee5fc8974f5df931a33cdcbc09c3da4da691a7
Gerrit-Change-Number: 22509
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Comment-Date: Wed, 26 Feb 2025 22:43:09 +0000
Gerrit-HasComments: Yes

[kudu-CR] [util] fix MetricsTest.TableAndTabletPrometheusTest

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/22509 )

Change subject: [util] fix MetricsTest.TableAndTabletPrometheusTest
......................................................................


Patch Set 1: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/22509
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I15ee5fc8974f5df931a33cdcbc09c3da4da691a7
Gerrit-Change-Number: 22509
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Comment-Date: Fri, 21 Feb 2025 00:56:27 +0000
Gerrit-HasComments: No

[kudu-CR] [util] fix MetricsTest.TableAndTabletPrometheusTest

Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/22509 )

Change subject: [util] fix MetricsTest.TableAndTabletPrometheusTest
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/22509/1/src/kudu/util/metrics-test.cc
File src/kudu/util/metrics-test.cc:

http://gerrit.cloudera.org:8080/#/c/22509/1/src/kudu/util/metrics-test.cc@158
PS1, Line 158: 1111111111
> The reason of this change is two-fold:
I see, makes sense. Maybe leave one at 32 character length? Just in case the string becomes too long for prometheus for whatever reason we would be able to catch it?



-- 
To view, visit http://gerrit.cloudera.org:8080/22509
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I15ee5fc8974f5df931a33cdcbc09c3da4da691a7
Gerrit-Change-Number: 22509
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Comment-Date: Wed, 26 Feb 2025 03:00:44 +0000
Gerrit-HasComments: Yes

[kudu-CR] [util] fix MetricsTest.TableAndTabletPrometheusTest

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/22509 )

Change subject: [util] fix MetricsTest.TableAndTabletPrometheusTest
......................................................................

[util] fix MetricsTest.TableAndTabletPrometheusTest

Since different STL implementations might produce different ordering
in the metric entities' container (std::unordered_map), it was necessary
to amend the scenario to remove the hard-coded output template,
otherwise the scenario would fail at least on SLES15.

Change-Id: I15ee5fc8974f5df931a33cdcbc09c3da4da691a7
Reviewed-on: http://gerrit.cloudera.org:8080/22509
Tested-by: Kudu Jenkins
Reviewed-by: Abhishek Chennaka <ac...@cloudera.com>
---
M src/kudu/util/metrics-test.cc
1 file changed, 54 insertions(+), 33 deletions(-)

Approvals:
  Kudu Jenkins: Verified
  Abhishek Chennaka: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/22509
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I15ee5fc8974f5df931a33cdcbc09c3da4da691a7
Gerrit-Change-Number: 22509
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>

[kudu-CR] [util] fix MetricsTest.TableAndTabletPrometheusTest

Posted by "Marton Greber (Code Review)" <ge...@cloudera.org>.
Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/22509 )

Change subject: [util] fix MetricsTest.TableAndTabletPrometheusTest
......................................................................


Patch Set 1: Code-Review+2

LGTM, the test looks more robust this way.
Thanks!


-- 
To view, visit http://gerrit.cloudera.org:8080/22509
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I15ee5fc8974f5df931a33cdcbc09c3da4da691a7
Gerrit-Change-Number: 22509
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Comment-Date: Tue, 25 Feb 2025 19:23:57 +0000
Gerrit-HasComments: No

[kudu-CR] [util] fix MetricsTest.TableAndTabletPrometheusTest

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22509 )

Change subject: [util] fix MetricsTest.TableAndTabletPrometheusTest
......................................................................


Patch Set 2: Verified+1

Build Successful 

http://jenkins.kudu.apache.org/job/pre_commit/1120/ : SUCCESS


-- 
To view, visit http://gerrit.cloudera.org:8080/22509
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I15ee5fc8974f5df931a33cdcbc09c3da4da691a7
Gerrit-Change-Number: 22509
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Comment-Date: Wed, 26 Feb 2025 06:50:04 +0000
Gerrit-HasComments: No

[kudu-CR] [util] fix MetricsTest.TableAndTabletPrometheusTest

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.

Change subject: [util] fix MetricsTest.TableAndTabletPrometheusTest
......................................................................


Removed Verified-1 by Kudu Jenkins (120)
-- 
To view, visit http://gerrit.cloudera.org:8080/22509
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I15ee5fc8974f5df931a33cdcbc09c3da4da691a7
Gerrit-Change-Number: 22509
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>