[GitHub] [hive] pkumarsinha commented on a change in pull request #1040: HIVE-23514 : Add Atlas metadata replication metrics

[GitBox <gi...@apache.org>]

pkumarsinha commented on a change in pull request #1040:
URL: https://github.com/apache/hive/pull/1040#discussion_r432583117



##########
File path: ql/src/java/org/apache/hadoop/hive/ql/exec/repl/AtlasDumpTask.java
##########
@@ -73,7 +74,12 @@ public int execute() {
       String entityGuid = checkHiveEntityGuid(atlasRequestBuilder, atlasReplInfo.getSrcCluster(),
               atlasReplInfo.getSrcDB());
       long currentModifiedTime = getCurrentTimestamp(atlasReplInfo, entityGuid);
-      dumpAtlasMetaData(atlasRequestBuilder, atlasReplInfo);
+      AtlasDumpLogger replLogger = new AtlasDumpLogger(atlasReplInfo.getSrcDB(),
+              atlasReplInfo.getStagingDir().toString());
+      replLogger.startLog();

Review comment:
       dumpAtlasMetaData is doing actual dump, shouldn't we capture time taken the complete dump and not just a particular step? 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org