You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@openoffice.apache.org by al...@apache.org on 2013/09/04 17:58:19 UTC

svn commit: r1520057 - /openoffice/trunk/main/svx/source/svdraw/svdoashp.cxx

Author: alg
Date: Wed Sep  4 15:58:19 2013
New Revision: 1520057

URL: http://svn.apache.org/r1520057
Log:
i123181 Corrected mirroring of shear angle in SdrObjCustomShape::TRSetBaseGeometry, this was wrong

Modified:
    openoffice/trunk/main/svx/source/svdraw/svdoashp.cxx

Modified: openoffice/trunk/main/svx/source/svdraw/svdoashp.cxx
URL: http://svn.apache.org/viewvc/openoffice/trunk/main/svx/source/svdraw/svdoashp.cxx?rev=1520057&r1=1520056&r2=1520057&view=diff
==============================================================================
--- openoffice/trunk/main/svx/source/svdraw/svdoashp.cxx (original)
+++ openoffice/trunk/main/svx/source/svdraw/svdoashp.cxx Wed Sep  4 15:58:19 2013
@@ -3343,8 +3343,10 @@ void SdrObjCustomShape::TRSetBaseGeometr
 	if(!basegfx::fTools::equalZero(fShearX))
 	{
 		GeoStat aGeoStat;
-        // #121932# do *not* forget to invert shearX(!)
-		aGeoStat.nShearWink = FRound((atan(-fShearX) / F_PI180) * 100.0);
+        // #123181# The fix for #121932# here was wrong, the trunk version does not correct the
+        // mirrored shear values, neither at the object level, nor on the API or XML level. Taking
+        // back the mirroring of the shear angle
+		aGeoStat.nShearWink = FRound((atan(fShearX) / F_PI180) * 100.0);
 		aGeoStat.RecalcTan();
 		Shear(Point(), aGeoStat.nShearWink, aGeoStat.nTan, sal_False);
 	}