You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/06/27 15:00:31 UTC

[GitHub] [kafka] omkreddy opened a new pull request #8937: MINOR: Create ChannelBuilder for each connection in ConnectionStressWorker workload

omkreddy opened a new pull request #8937:
URL: https://github.com/apache/kafka/pull/8937


   - Currently we create single channel builder and reuse it in ConnectStressor workload.  This will fail when testing with secure connections, as we close channel builder after first connection.  This PR creates  ChannelBuilder for each test connection. 
   - Also increase to connect ready wait timeout to 500ms. 
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] ijuma commented on a change in pull request #8937: MINOR: Create ChannelBuilder for each connection in ConnectionStressWorker workload

Posted by GitBox <gi...@apache.org>.
ijuma commented on a change in pull request #8937:
URL: https://github.com/apache/kafka/pull/8937#discussion_r446667029



##########
File path: tools/src/main/java/org/apache/kafka/trogdor/workload/ConnectionStressWorker.java
##########
@@ -192,7 +191,6 @@ public boolean tryConnect() {
         @Override
         public void close() throws Exception {
             Utils.closeQuietly(updater, "ManualMetadataUpdater");
-            Utils.closeQuietly(channelBuilder, "ChannelBuilder");

Review comment:
       Worth explaining how the channel builder is closed now.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] omkreddy closed pull request #8937: MINOR: Create ChannelBuilder for each connection in ConnectionStressWorker workload

Posted by GitBox <gi...@apache.org>.
omkreddy closed pull request #8937:
URL: https://github.com/apache/kafka/pull/8937


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org