[Impala-ASF-CR] IMPALA-7140 (part 8): support views in LocalCatalog

["Todd Lipcon (Code Review)" <ge...@cloudera.org>]

Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/10805 )

Change subject: IMPALA-7140 (part 8): support views in LocalCatalog
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/10805/1/fe/src/main/java/org/apache/impala/catalog/local/LocalView.java
File fe/src/main/java/org/apache/impala/catalog/local/LocalView.java:

http://gerrit.cloudera.org:8080/#/c/10805/1/fe/src/main/java/org/apache/impala/catalog/local/LocalView.java@61
PS1, Line 61: previous 'View'
> nit: slightly confusing since its still there. how about just replacing thi
Done


http://gerrit.cloudera.org:8080/#/c/10805/1/fe/src/main/java/org/apache/impala/catalog/local/LocalView.java@73
PS1, Line 73: ull
> sp: null
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/10805
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib3516b9ceff6dce12ded68d93afde09728627e08
Gerrit-Change-Number: 10805
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>
Gerrit-Comment-Date: Fri, 06 Jul 2018 17:25:37 +0000
Gerrit-HasComments: Yes