You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by GitBox <gi...@apache.org> on 2020/06/08 05:48:54 UTC

[GitHub] [trafficserver] maskit opened a new pull request #6861: Fix a crash on TLS resumption

maskit opened a new pull request #6861:
URL: https://github.com/apache/trafficserver/pull/6861


   A possible fix for the crash on TLS resumption.
   
   The crash seems to be caused by a small change made on ##6736. On the PR, I added `this->_setSSLCurveNID(SSLGetCurveNID(ssl));` after a call for `_setSSLSessionCacheHit` for consistency, but I realized it doesn't make sense in `_getSessionInformation`.
   
   So I removed the line and added a code similar to `fetch_ssl_curve`, which was removed on #6736.
   
    I couldn't reproduce the crash by myself and CI tests don't catch the crash somehow, so please ran this locally if you can reproduce the crash.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [trafficserver] shinrich commented on pull request #6861: Fix a crash on TLS resumption

Posted by GitBox <gi...@apache.org>.
shinrich commented on pull request #6861:
URL: https://github.com/apache/trafficserver/pull/6861#issuecomment-640578188






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [trafficserver] maskit commented on pull request #6861: Fix a crash on TLS resumption

Posted by GitBox <gi...@apache.org>.
maskit commented on pull request #6861:
URL: https://github.com/apache/trafficserver/pull/6861#issuecomment-641657763


   You're right. We don't need this for 8.1.x as long as we don't backport #6736.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [trafficserver] zwoop commented on pull request #6861: Fix a crash on TLS resumption

Posted by GitBox <gi...@apache.org>.
zwoop commented on pull request #6861:
URL: https://github.com/apache/trafficserver/pull/6861#issuecomment-641521268


   Cherry-picked to v9.0.x branch.
   
   I assume we don't need this for 8.1.x ?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [trafficserver] maskit merged pull request #6861: Fix a crash on TLS resumption

Posted by GitBox <gi...@apache.org>.
maskit merged pull request #6861:
URL: https://github.com/apache/trafficserver/pull/6861


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org