You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/04/19 04:35:44 UTC

[GitHub] [pulsar] wolfstudy commented on a change in pull request #6752: Support different docker images in Kubernetes runtime of Pulsar Functions

wolfstudy commented on a change in pull request #6752: Support different docker images in Kubernetes runtime of Pulsar Functions
URL: https://github.com/apache/pulsar/pull/6752#discussion_r410812868
 
 

 ##########
 File path: pulsar-functions/runtime/src/main/java/org/apache/pulsar/functions/runtime/kubernetes/KubernetesRuntime.java
 ##########
 @@ -155,6 +158,9 @@
                       String pythonDependencyRepository,
                       String pythonExtraDependencyRepository,
                       String pulsarDockerImageName,
+                      String javaFunctionDockerImageName,
+                      String pythonFunctionDockerImageName,
+                      String goFunctionDockerImageName,
 
 Review comment:
   > Is there another patch coming with this? The kubernetes runtime only supports one docker image right?. So, If I configured a python image I would only be able to run python functions.
   
   Yes, this is what I want to achieve. Currently, the default docker image we use is `apachepulsar/pulsar-all`, but sometimes users only want to use the Python Function, then for Java Function and Go Function, we don’t need to build related dependencies to the image, right?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services