You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/03/26 14:09:11 UTC

[GitHub] [incubator-nuttx] patacongo edited a comment on issue #625: Makefile: move INCDIROPT to common place

patacongo edited a comment on issue #625: Makefile: move INCDIROPT to common place
URL: https://github.com/apache/incubator-nuttx/pull/625#issuecomment-604450218
 
 
   This change effects systems using Cygwin under windows with Windos native toolchain.  In that case WINTOOLS will be defined and the -w option must be used.  Has that been verified?  This change should not be merged if that test case has not been verified.
   
   This is the build configuration that I use Windows Cygwin plus Windows native toolchan and this looks to me like it would break my build.
   
   Mmm.. Isee that the -w was added in Config.mk.  Perhaps there is no issue.  We need to have a test case for this configuration!  Merging the change is a very big risk with no testing.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services