You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/01/02 06:01:12 UTC

[GitHub] [flink] godfreyhe edited a comment on issue #10694: [FLINK-15381] [table-planner-blink] correct collation derive logic on RelSubset in RelMdCollation

godfreyhe edited a comment on issue #10694: [FLINK-15381] [table-planner-blink] correct collation derive logic on RelSubset in RelMdCollation
URL: https://github.com/apache/flink/pull/10694#issuecomment-570124600
 
 
   > I'm agreed with you.
   > However it's unsafe to throw exception in the else branch.
   
   `FlinkRelMdUniqueKeys` and `FlinkRelMdUniqueGroups` also throw exception for this case and there are many test cases will fail once CALCITE_1048 is fixed

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services