You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2021/03/18 11:51:33 UTC

[GitHub] [shardingsphere] yu199195 opened a new pull request #9734: database discovery and read write splitting integration aware

yu199195 opened a new pull request #9734:
URL: https://github.com/apache/shardingsphere/pull/9734


   about #9590 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] codecov-io edited a comment on pull request #9734: database discovery and read write splitting integration aware

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9734:
URL: https://github.com/apache/shardingsphere/pull/9734#issuecomment-801918049


   # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/9734?src=pr&el=h1) Report
   > Merging [#9734](https://codecov.io/gh/apache/shardingsphere/pull/9734?src=pr&el=desc) (38def79) into [master](https://codecov.io/gh/apache/shardingsphere/commit/e1119bf24500fd6fa8280ee9d1aac60379891ee2?el=desc) (e1119bf) will **increase** coverage by `0.44%`.
   > The diff coverage is `47.61%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/shardingsphere/pull/9734/graphs/tree.svg?width=650&height=150&src=pr&token=ZvlXpWa7so)](https://codecov.io/gh/apache/shardingsphere/pull/9734?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #9734      +/-   ##
   ============================================
   + Coverage     67.29%   67.73%   +0.44%     
   + Complexity      685      681       -4     
   ============================================
     Files          1663     1663              
     Lines         27776    27639     -137     
     Branches       4940     4890      -50     
   ============================================
   + Hits          18692    18722      +30     
   + Misses         7710     7539     -171     
   - Partials       1374     1378       +4     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/9734?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...y/common/rule/DatabaseDiscoveryDataSourceRule.java](https://codecov.io/gh/apache/shardingsphere/pull/9734/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtZGItZGlzY292ZXJ5L3NoYXJkaW5nc3BoZXJlLWRiLWRpc2NvdmVyeS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RiL2Rpc2NvdmVyeS9jb21tb24vcnVsZS9EYXRhYmFzZURpc2NvdmVyeURhdGFTb3VyY2VSdWxlLmphdmE=) | `95.65% <0.00%> (-4.35%)` | `0.00 <0.00> (ø)` | |
   | [...ReadWriteSplittingDataSourceRuleConfiguration.java](https://codecov.io/gh/apache/shardingsphere/pull/9734/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtcmVhZC13cml0ZS1zcGxpdHRpbmcvc2hhcmRpbmdzcGhlcmUtcmVhZC13cml0ZS1zcGxpdHRpbmctY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9yZWFkd3JpdGUvc3BsaXR0aW5nL2NvbW1vbi95YW1sL2NvbmZpZy9ydWxlL1lhbWxSZWFkV3JpdGVTcGxpdHRpbmdEYXRhU291cmNlUnVsZUNvbmZpZ3VyYXRpb24uamF2YQ==) | `100.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | [...sphere/infra/aware/DataSourceNameAwareFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/9734/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9hd2FyZS9EYXRhU291cmNlTmFtZUF3YXJlRmFjdG9yeS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...ardingsphere/infra/spi/typed/TypedSPIRegistry.java](https://codecov.io/gh/apache/shardingsphere/pull/9734/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9zcGkvdHlwZWQvVHlwZWRTUElSZWdpc3RyeS5qYXZh) | `85.00% <0.00%> (-4.48%)` | `0.00 <0.00> (ø)` | |
   | [...ngine/impl/ReadWriteSplittingDataSourceRouter.java](https://codecov.io/gh/apache/shardingsphere/pull/9734/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtcmVhZC13cml0ZS1zcGxpdHRpbmcvc2hhcmRpbmdzcGhlcmUtcmVhZC13cml0ZS1zcGxpdHRpbmctcm91dGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3JlYWR3cml0ZS9zcGxpdHRpbmcvcm91dGUvZW5naW5lL2ltcGwvUmVhZFdyaXRlU3BsaXR0aW5nRGF0YVNvdXJjZVJvdXRlci5qYXZh) | `38.88% <30.76%> (-44.45%)` | `0.00 <0.00> (ø)` | |
   | [...on/aware/DatabaseDiscoveryDataSourceNameAware.java](https://codecov.io/gh/apache/shardingsphere/pull/9734/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtZGItZGlzY292ZXJ5L3NoYXJkaW5nc3BoZXJlLWRiLWRpc2NvdmVyeS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RiL2Rpc2NvdmVyeS9jb21tb24vYXdhcmUvRGF0YWJhc2VEaXNjb3ZlcnlEYXRhU291cmNlTmFtZUF3YXJlLmphdmE=) | `50.00% <50.00%> (ø)` | `1.00 <1.00> (?)` | |
   | [.../common/rule/ReadWriteSplittingDataSourceRule.java](https://codecov.io/gh/apache/shardingsphere/pull/9734/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtcmVhZC13cml0ZS1zcGxpdHRpbmcvc2hhcmRpbmdzcGhlcmUtcmVhZC13cml0ZS1zcGxpdHRpbmctY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9yZWFkd3JpdGUvc3BsaXR0aW5nL2NvbW1vbi9ydWxlL1JlYWRXcml0ZVNwbGl0dGluZ0RhdGFTb3VyY2VSdWxlLmphdmE=) | `83.33% <54.54%> (-16.67%)` | `0.00 <0.00> (ø)` | |
   | [...actReadWriteSplittingRuleConfigurationChecker.java](https://codecov.io/gh/apache/shardingsphere/pull/9734/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZ292ZXJuYW5jZS9zaGFyZGluZ3NwaGVyZS1nb3Zlcm5hbmNlLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2dvdmVybmFuY2UvY29yZS9yZWdpc3RyeS9jaGVja2VyL0Fic3RyYWN0UmVhZFdyaXRlU3BsaXR0aW5nUnVsZUNvbmZpZ3VyYXRpb25DaGVja2VyLmphdmE=) | `71.42% <60.00%> (-3.58%)` | `1.00 <0.00> (ø)` | |
   | [...b/discovery/common/rule/DatabaseDiscoveryRule.java](https://codecov.io/gh/apache/shardingsphere/pull/9734/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtZGItZGlzY292ZXJ5L3NoYXJkaW5nc3BoZXJlLWRiLWRpc2NvdmVyeS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RiL2Rpc2NvdmVyeS9jb21tb24vcnVsZS9EYXRhYmFzZURpc2NvdmVyeVJ1bGUuamF2YQ==) | `53.65% <66.66%> (+3.65%)` | `0.00 <0.00> (ø)` | |
   | [...mon/rule/biulder/DatabaseDiscoveryRuleBuilder.java](https://codecov.io/gh/apache/shardingsphere/pull/9734/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtZGItZGlzY292ZXJ5L3NoYXJkaW5nc3BoZXJlLWRiLWRpc2NvdmVyeS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RiL2Rpc2NvdmVyeS9jb21tb24vcnVsZS9iaXVsZGVyL0RhdGFiYXNlRGlzY292ZXJ5UnVsZUJ1aWxkZXIuamF2YQ==) | `100.00% <100.00%> (+10.00%)` | `1.00 <0.00> (-1.00)` | :arrow_up: |
   | ... and [40 more](https://codecov.io/gh/apache/shardingsphere/pull/9734/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/9734?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/9734?src=pr&el=footer). Last update [e1119bf...38def79](https://codecov.io/gh/apache/shardingsphere/pull/9734?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] tuohai666 merged pull request #9734: database discovery and read write splitting integration aware

Posted by GitBox <gi...@apache.org>.
tuohai666 merged pull request #9734:
URL: https://github.com/apache/shardingsphere/pull/9734


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] codecov-io commented on pull request #9734: database discovery and read write splitting integration aware

Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #9734:
URL: https://github.com/apache/shardingsphere/pull/9734#issuecomment-801918049


   # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/9734?src=pr&el=h1) Report
   > Merging [#9734](https://codecov.io/gh/apache/shardingsphere/pull/9734?src=pr&el=desc) (1d10b60) into [master](https://codecov.io/gh/apache/shardingsphere/commit/e1119bf24500fd6fa8280ee9d1aac60379891ee2?el=desc) (e1119bf) will **increase** coverage by `0.13%`.
   > The diff coverage is `47.61%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/shardingsphere/pull/9734/graphs/tree.svg?width=650&height=150&src=pr&token=ZvlXpWa7so)](https://codecov.io/gh/apache/shardingsphere/pull/9734?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #9734      +/-   ##
   ============================================
   + Coverage     67.29%   67.43%   +0.13%     
   + Complexity      685      681       -4     
   ============================================
     Files          1663     1663              
     Lines         27776    27765      -11     
     Branches       4940     4935       -5     
   ============================================
   + Hits          18692    18722      +30     
   + Misses         7710     7665      -45     
   - Partials       1374     1378       +4     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/9734?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...y/common/rule/DatabaseDiscoveryDataSourceRule.java](https://codecov.io/gh/apache/shardingsphere/pull/9734/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtZGItZGlzY292ZXJ5L3NoYXJkaW5nc3BoZXJlLWRiLWRpc2NvdmVyeS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RiL2Rpc2NvdmVyeS9jb21tb24vcnVsZS9EYXRhYmFzZURpc2NvdmVyeURhdGFTb3VyY2VSdWxlLmphdmE=) | `95.65% <0.00%> (-4.35%)` | `0.00 <0.00> (ø)` | |
   | [...ReadWriteSplittingDataSourceRuleConfiguration.java](https://codecov.io/gh/apache/shardingsphere/pull/9734/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtcmVhZC13cml0ZS1zcGxpdHRpbmcvc2hhcmRpbmdzcGhlcmUtcmVhZC13cml0ZS1zcGxpdHRpbmctY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9yZWFkd3JpdGUvc3BsaXR0aW5nL2NvbW1vbi95YW1sL2NvbmZpZy9ydWxlL1lhbWxSZWFkV3JpdGVTcGxpdHRpbmdEYXRhU291cmNlUnVsZUNvbmZpZ3VyYXRpb24uamF2YQ==) | `100.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | [...sphere/infra/aware/DataSourceNameAwareFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/9734/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9hd2FyZS9EYXRhU291cmNlTmFtZUF3YXJlRmFjdG9yeS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...ardingsphere/infra/spi/typed/TypedSPIRegistry.java](https://codecov.io/gh/apache/shardingsphere/pull/9734/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9zcGkvdHlwZWQvVHlwZWRTUElSZWdpc3RyeS5qYXZh) | `85.00% <0.00%> (-4.48%)` | `0.00 <0.00> (ø)` | |
   | [...ngine/impl/ReadWriteSplittingDataSourceRouter.java](https://codecov.io/gh/apache/shardingsphere/pull/9734/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtcmVhZC13cml0ZS1zcGxpdHRpbmcvc2hhcmRpbmdzcGhlcmUtcmVhZC13cml0ZS1zcGxpdHRpbmctcm91dGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3JlYWR3cml0ZS9zcGxpdHRpbmcvcm91dGUvZW5naW5lL2ltcGwvUmVhZFdyaXRlU3BsaXR0aW5nRGF0YVNvdXJjZVJvdXRlci5qYXZh) | `38.88% <30.76%> (-44.45%)` | `0.00 <0.00> (ø)` | |
   | [...on/aware/DatabaseDiscoveryDataSourceNameAware.java](https://codecov.io/gh/apache/shardingsphere/pull/9734/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtZGItZGlzY292ZXJ5L3NoYXJkaW5nc3BoZXJlLWRiLWRpc2NvdmVyeS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RiL2Rpc2NvdmVyeS9jb21tb24vYXdhcmUvRGF0YWJhc2VEaXNjb3ZlcnlEYXRhU291cmNlTmFtZUF3YXJlLmphdmE=) | `50.00% <50.00%> (ø)` | `1.00 <1.00> (?)` | |
   | [.../common/rule/ReadWriteSplittingDataSourceRule.java](https://codecov.io/gh/apache/shardingsphere/pull/9734/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtcmVhZC13cml0ZS1zcGxpdHRpbmcvc2hhcmRpbmdzcGhlcmUtcmVhZC13cml0ZS1zcGxpdHRpbmctY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9yZWFkd3JpdGUvc3BsaXR0aW5nL2NvbW1vbi9ydWxlL1JlYWRXcml0ZVNwbGl0dGluZ0RhdGFTb3VyY2VSdWxlLmphdmE=) | `83.33% <54.54%> (-16.67%)` | `0.00 <0.00> (ø)` | |
   | [...actReadWriteSplittingRuleConfigurationChecker.java](https://codecov.io/gh/apache/shardingsphere/pull/9734/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZ292ZXJuYW5jZS9zaGFyZGluZ3NwaGVyZS1nb3Zlcm5hbmNlLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2dvdmVybmFuY2UvY29yZS9yZWdpc3RyeS9jaGVja2VyL0Fic3RyYWN0UmVhZFdyaXRlU3BsaXR0aW5nUnVsZUNvbmZpZ3VyYXRpb25DaGVja2VyLmphdmE=) | `71.42% <60.00%> (-3.58%)` | `1.00 <0.00> (ø)` | |
   | [...b/discovery/common/rule/DatabaseDiscoveryRule.java](https://codecov.io/gh/apache/shardingsphere/pull/9734/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtZGItZGlzY292ZXJ5L3NoYXJkaW5nc3BoZXJlLWRiLWRpc2NvdmVyeS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RiL2Rpc2NvdmVyeS9jb21tb24vcnVsZS9EYXRhYmFzZURpc2NvdmVyeVJ1bGUuamF2YQ==) | `53.65% <66.66%> (+3.65%)` | `0.00 <0.00> (ø)` | |
   | [...mon/rule/biulder/DatabaseDiscoveryRuleBuilder.java](https://codecov.io/gh/apache/shardingsphere/pull/9734/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtZGItZGlzY292ZXJ5L3NoYXJkaW5nc3BoZXJlLWRiLWRpc2NvdmVyeS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RiL2Rpc2NvdmVyeS9jb21tb24vcnVsZS9iaXVsZGVyL0RhdGFiYXNlRGlzY292ZXJ5UnVsZUJ1aWxkZXIuamF2YQ==) | `100.00% <100.00%> (+10.00%)` | `1.00 <0.00> (-1.00)` | :arrow_up: |
   | ... and [39 more](https://codecov.io/gh/apache/shardingsphere/pull/9734/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/9734?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/9734?src=pr&el=footer). Last update [e1119bf...1d10b60](https://codecov.io/gh/apache/shardingsphere/pull/9734?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org